From owner-svn-src-head@freebsd.org Sat Dec 30 21:42:29 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD489EAE1A2 for ; Sat, 30 Dec 2017 21:42:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 80CA66EE2D for ; Sat, 30 Dec 2017 21:42:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22c.google.com with SMTP id u62so33993709ita.2 for ; Sat, 30 Dec 2017 13:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ZnUWSlBEV+cgTb83wpTLafvhPkg1vMXp17+v9QLN8Is=; b=Ke114vm4Fy8B6XY/UtZXls+V7NluiyZp0QLG5pjr/mwg/l4Q+3W0q7L5W5ZLRZpavr 6n6maXBiNhwqmyinXUYLjZ5ckCsXw1Pr69gUO4M/jWS4fpZ+Sgc7GF2MVMckkwcxKOo9 bRGWn3BAF6wj19a3mWrsJSwtaknPx2wYg+MVwbY8jwT0qenBXMihPqn3Hcy9a/IOHW4B Yqgvfe/yb2YENKjGVJsHmS9XCerRI14X6fZ25Tnc+eXAm34nxDbZij+b6hBcE4GxMvmK RdoQEyjdsWbWWuz0HvbXx2gN3kW2ASb9XWoRMAPrNPA5pj2h+aNabUsFYDBlWBXXDyRL Y9mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ZnUWSlBEV+cgTb83wpTLafvhPkg1vMXp17+v9QLN8Is=; b=CFk+wSSDwbQUXZZ9WKVh+lzwpjIntkWKWGccW8CLh0wE1sDEB8gv5rmu7kunh4hOrA W0VzmOuDm20i+QiJ6M6MpLSZuTadDQk3g0Uy8o3Qv1rDSGrZXT+BVXrHW5QL5oFRdCTw iElFWBOfU/5O7YPQtHxb61akzOZ4qlRXN64wbTFQCuGZ84jZwAo32Uyvq6NH1Igm1OEG Dl2I20/sTW84Uvw+ilQb9b0UKHfkwEe8/6lvJbIAnDUSX0Vq+mX43hRkxyd44bY3AMu7 aKWag65YVlAKc6BnJe2dJbarzLcPr6j9gBbMkOmWlwUAkuy2oU3Etelu0n35emkDSh/K NNxQ== X-Gm-Message-State: AKGB3mJD5mP2478N8ENo59FkHNJMq2LRjBOnd6tqQr9jsSsn3I32Bov7 nWggG3gn+A/ROl0zAkwe1ZmWb6fbNgj74EFYxWSn7A== X-Google-Smtp-Source: ACJfBovYqnkPfMU8O/IRjQVkYTD5WGGb2da/2IfAw2t6De1zBxI014zw4hBCUdaXOXlHVumAbIkZzp0v/9jzqVA9Fzw= X-Received: by 10.36.133.135 with SMTP id r129mr53905833itd.69.1514670148812; Sat, 30 Dec 2017 13:42:28 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Sat, 30 Dec 2017 13:42:28 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <20171230211428.GU1684@kib.kiev.ua> References: <201712301142.vBUBgnXl095227@repo.freebsd.org> <20171230211428.GU1684@kib.kiev.ua> From: Warner Losh Date: Sat, 30 Dec 2017 14:42:28 -0700 X-Google-Sender-Auth: tdVvO2qampxYEy6KXjfDMDM2a10 Message-ID: Subject: Re: svn commit: r327381 - in head/sys: conf dev/ep i386/isa modules modules/elink modules/ep To: Konstantin Belousov Cc: Pedro Giffuni , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Dec 2017 21:42:29 -0000 On Sat, Dec 30, 2017 at 2:14 PM, Konstantin Belousov wrote: > On Sat, Dec 30, 2017 at 04:02:39PM -0500, Pedro Giffuni wrote: > > Hi; > > > > On 30/12/2017 06:42, Konstantin Belousov wrote: > > > Author: kib > > > Date: Sat Dec 30 11:42:49 2017 > > > New Revision: 327381 > > > URL: https://svnweb.freebsd.org/changeset/base/327381 > > > > > > Log: > > > Move i386/isa/elink.[hc] to dev/ep. > > > > > > The ep(4) driver is the only consumer of the two functions from > > > elink.c. I removed the standalone module as well, and most likely, > > > the module metadata is not needed anywhere, but this is for later > > > cleanup. > > > > > > Discussed with: imp, jhb > > > Sponsored by: The FreeBSD Foundation > > For the record, I find this change very cool. > > > > It makes the code more modular and the license for those two files also > > matches the license in the ep driver. > > The idea of this change and r327380 is to clean up i386/isa. There are > three more files to go > Originally, the ie driver and the ep driver shared the elink code since there were two different drivers, but the same pre-PNP discovery method for these cards. It makes sense to do what was just done now that ie is gone. Warner