Date: Tue, 4 Jan 2011 13:49:40 +0000 From: Alexander Best <arundel@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Kostik Belousov <kostikbel@gmail.com>, freebsd-hackers@freebsd.org, hackers@freebsd.org, Giorgos Keramidas <keramida@freebsd.org>, Eitan Adler <lists@eitanadler.com> Subject: Re: [patch] have rtprio check that arguments are numeric; change atoi to strtol Message-ID: <20110104134940.GA8529@freebsd.org> In-Reply-To: <201101040805.59412.jhb@freebsd.org> References: <AANLkTimiJPiHBSw5i5TVJYfh9uGOyrNJx%2BoUPeB%2Bt%2BY_@mail.gmail.com> <xeia7heluf2q.fsf@kobe.laptop> <20110104112502.GM3140@deviant.kiev.zoral.com.ua> <201101040805.59412.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue Jan 4 11, John Baldwin wrote:
> On Tuesday, January 04, 2011 6:25:02 am Kostik Belousov wrote:
> > On Tue, Jan 04, 2011 at 11:40:45AM +0100, Giorgos Keramidas wrote:
> > @@ -123,12 +121,28 @@ main(argc, argv)
> > }
> > exit(0);
> > }
> > - exit (1);
> > + exit(1);
> > +}
> > +
> > +static int
> > +parseint(const char *str, const char *errname)
> > +{
> > + char *endp;
> > + long res;
> > +
> > + errno = 0;
> > + res = strtol(str, &endp, 10);
> > + if (errno != 0 || endp == str || *endp != '\0')
> > + err(1, "%s shall be a number", errname);
>
> Small nit, maybe use 'must' instead of 'shall'.
it seems at some point there has been a massive usage of the term 'shall' in
manual pages, which people tried to get rid of. hence the
'usr/share/examples/mdoc/deshallify.sh' script.
maybe this should be noted in style(9)?
cheers.
alex
>
> --
> John Baldwin
--
a13x
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110104134940.GA8529>