From owner-freebsd-bugs@FreeBSD.ORG Fri Jan 15 22:30:03 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2325106566C for ; Fri, 15 Jan 2010 22:30:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D0F438FC0A for ; Fri, 15 Jan 2010 22:30:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0FMU3RU071145 for ; Fri, 15 Jan 2010 22:30:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0FMU3KY071140; Fri, 15 Jan 2010 22:30:03 GMT (envelope-from gnats) Date: Fri, 15 Jan 2010 22:30:03 GMT Message-Id: <201001152230.o0FMU3KY071140@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Maxim Zakharov Cc: Subject: Re: kern/141682: [libc] [patch] Faster version of strncpy(3) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Maxim Zakharov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2010 22:30:04 -0000 The following reply was made to PR kern/141682; it has been noted by GNATS. From: Maxim Zakharov To: Jaakko Heinonen Cc: bug-followup@freebsd.org Subject: Re: kern/141682: [libc] [patch] Faster version of strncpy(3) Date: Sat, 16 Jan 2010 01:26:03 +0300 Hi, if (length) { register size_t n = length / 8; register size_t r = (length % 8); register char *dst = dst0, *src = src0; if (r == 0) r = 8; else n++; this solves the problem. Thank you. On 1/15/10, Jaakko Heinonen wrote: > > Hi, > > On 2009-12-17, Maxim Zakharov wrote: >> void * dps_strncpy(char *dst0, char *src0, size_t length) { >> if (length) { >> register size_t n = (length + 7) / 8; > > This won't work with length values larger than SIZE_MAX - 7 due to > integer overflow. > > -- > Jaakko > -- http://www.dataparksearch.org/