From owner-cvs-all@FreeBSD.ORG  Wed Apr 30 15:58:52 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EFDB137B401; Wed, 30 Apr 2003 15:58:51 -0700 (PDT)
Received: from espresso.bsdmike.org (espresso.bsdmike.org [65.39.129.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 64DCE43FA3; Wed, 30 Apr 2003 15:58:51 -0700 (PDT)
	(envelope-from mike@espresso.bsdmike.org)
Received: by espresso.bsdmike.org (Postfix, from userid 1002)
	id 6C7799C84; Wed, 30 Apr 2003 18:43:51 -0400 (EDT)
Date: Wed, 30 Apr 2003 18:43:51 -0400
From: Mike Barcroft <mike@FreeBSD.org>
To: Mark Murray <markm@FreeBSD.org>
Message-ID: <20030430184351.B31859@espresso.bsdmike.org>
References: <200304301223.h3UCNwOW056381@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200304301223.h3UCNwOW056381@repoman.freebsd.org>;
	from markm@FreeBSD.org on Wed, Apr 30, 2003 at 05:23:58AM -0700
Organization: The FreeBSD Project
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/i386 identcpu.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Apr 2003 22:58:52 -0000

Mark Murray <markm@FreeBSD.org> writes:
> markm       2003/04/30 05:23:58 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/i386/i386        identcpu.c 
>   Log:
>   Warns fixing. Protect against inappropriate linting, and mark
>   GCC-specific assemble code as such (in #ifdefs). Fix an easy
>   static variable warning while I'm here.
>   
>   Revision  Changes    Path
>   1.122     +8 -1      src/sys/i386/i386/identcpu.c

Is it really useful to #ifdef critical sections of code.  This thing
isn't going to compile without asm extentions from the compiler.  So
really you just turn compile errors into link error.  Not very helpful
IMO.

Also, you added an used #else clause near the top.

Best regards,
Mike Barcroft