From owner-svn-src-head@FreeBSD.ORG  Mon Jun  7 20:07:59 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A25D31065670;
	Mon,  7 Jun 2010 20:07:59 +0000 (UTC)
	(envelope-from pjd@garage.freebsd.pl)
Received: from mail.garage.freebsd.pl (chello089077043238.chello.pl
	[89.77.43.238])
	by mx1.freebsd.org (Postfix) with ESMTP id D571C8FC14;
	Mon,  7 Jun 2010 20:07:58 +0000 (UTC)
Received: by mail.garage.freebsd.pl (Postfix, from userid 65534)
	id AA4E445CD8; Mon,  7 Jun 2010 22:07:55 +0200 (CEST)
Received: from localhost (chello089077043238.chello.pl [89.77.43.238])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.garage.freebsd.pl (Postfix) with ESMTP id 6EF8445B36;
	Mon,  7 Jun 2010 22:07:49 +0200 (CEST)
Date: Mon, 7 Jun 2010 22:07:43 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Randall Stewart <rrs@FreeBSD.org>
Message-ID: <20100607200743.GB4468@garage.freebsd.pl>
References: <201006061611.o56GBHbE089883@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="+pHx0qQiF2pBVqBT"
Content-Disposition: inline
In-Reply-To: <201006061611.o56GBHbE089883@svn.freebsd.org>
User-Agent: Mutt/1.4.2.3i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 9.0-CURRENT amd64
X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on 
	mail.garage.freebsd.pl
X-Spam-Level: 
X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL 
	autolearn=no version=3.0.4
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r208876 - head/sys/netinet
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jun 2010 20:07:59 -0000


--+pHx0qQiF2pBVqBT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 06, 2010 at 04:11:17PM +0000, Randall Stewart wrote:
> Author: rrs
> Date: Sun Jun  6 16:11:16 2010
> New Revision: 208876
> URL: http://svn.freebsd.org/changeset/base/208876
>=20
> Log:
>   1) Further enhance the INVARIANT lock validation (no locks) are
>      held by checking the create and inp locks as well.
[...]
> +	if (mtx_owned(&inp->inp_create_mtx)) {
> +		panic("Own create lock on inp");
> +	}
> +	if (mtx_owned(&inp->inp_mtx)) {
> +		panic("Own inp lock on inp");
> +	}

If you replace this with:

	mtx_assert(&inp->inp_create_mtx, MA_NOTOWNED);
	mtx_assert(&inp->inp_mtx, MA_NOTOWNED);

But the kernel has to be compiled with INVARIANTS to make it work.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--+pHx0qQiF2pBVqBT
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iEYEARECAAYFAkwNUY8ACgkQForvXbEpPzQLJQCgnChrTlQpi4UdAyy6MwIxuaJY
qycAoMCM401xg8zGoSicT6vawOWvAvRo
=whM3
-----END PGP SIGNATURE-----

--+pHx0qQiF2pBVqBT--