From nobody Sun Jan 14 11:21:22 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TCXsG5MGQz57h9X; Sun, 14 Jan 2024 11:21:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TCXsG27y0z4svK; Sun, 14 Jan 2024 11:21:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705231282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/YjuzXZUGJo+XFc+/f8gmiGxYQoNBLfOjOLz/DTjk8Y=; b=ueMQlSAojZW9LHQbHflZRxya2CXG2cJrK5cFE3+7a/YJy6LSKnVQssi5ZTTNNWA8mmUjll 8wTzKhmkAiysABmH9cTqn50bYd8AyUoT4+OcA5PQVAVDRGXrO97jHjZeysxM8pgDnObqsI G1bcZEzhJVF5POZoSBu9xqyr5gL2uM8HJxCR7GUMruaZUVr+0fc32zhrYMrhZNOOQH/z9m 15UuGFtcXyrRy9U5urBmTzKA55E7tdyvm0/B/W01XyTggJ6GCRdhdtm3BM3BsEW2oZJaEm AFdJIOznmgDLkz+0CTsZ3INRYjkeE+ZSFUt91OExvAC5wCDMgMJIAgEm8mqNQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705231282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/YjuzXZUGJo+XFc+/f8gmiGxYQoNBLfOjOLz/DTjk8Y=; b=RTLkl+c6ZujGLG2dpwTbd6kE5FwxeyvLcr56+hdjEZnZyT2aTx3hxNCJbftktsRVFmyVaj 9d5cvSMa4BsU6aFrqTEssFKyYB10JSde6FjHo/4lRaiHTscvV8fsQW+10cEZqft7TFJ3Dj GLhnAjvC+9wrhXsTp+RMqNvgtozl5IKncpODdemn9iFAJ2R6SpJS5yiYmwr8cYb6NEzhzs b8bTu1yIWy7wb7EfqA760GnEcRATre6f1hiWHSD/RFFK1oSH+2HuucNvujHzdPiQjJjRZD GEVYWWo59lVkY7/3SL4/8n5mlVL45zYriLgbKjym9aHuJS3n11fun6EVremUig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705231282; a=rsa-sha256; cv=none; b=mrm9/UzIY8AeEEezPc3mek3MI9bvW8AdhQoU9lJ9q6Qro7Bm1vcgFFAe7ecO9+qkIcXsaL LLCGHlsbfu1vboTVH7/LlJmtuQoAA+2aQYUmon8kfl9voXvrB4ns7jsXyRWylve1xwyspG qqf5l/ryRslOiDPCfazlvlWagRmnfmtHxx4Q3O+Z8XoDOJUtKf9NuQPqkiZJRcxfx4aiUc Kvvdo+ePMey1bByktUsQwKpzSyHEb+JZQizKvzEGJRzvEVxbIqgdjiOS7YGkUAdBUEMrM+ oOcl+OW1TByxZClgxn/9y1d1IQJieNMl6RfxGljLPn2cDdxDpz5FMRsAMGINIg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TCXsG1Cw0z1BXl; Sun, 14 Jan 2024 11:21:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40EBLMbA083384; Sun, 14 Jan 2024 11:21:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40EBLMpO083381; Sun, 14 Jan 2024 11:21:22 GMT (envelope-from git) Date: Sun, 14 Jan 2024 11:21:22 GMT Message-Id: <202401141121.40EBLMpO083381@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Peter Grehan Subject: git: 0c243cd4a367 - main - Fix issue with Linux guest XHCI tablet probing. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: grehan X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0c243cd4a3671bf728f33378ac593c08d8367bc2 Auto-Submitted: auto-generated The branch main has been updated by grehan: URL: https://cgit.FreeBSD.org/src/commit/?id=0c243cd4a3671bf728f33378ac593c08d8367bc2 commit 0c243cd4a3671bf728f33378ac593c08d8367bc2 Author: Peter Grehan AuthorDate: 2024-01-14 11:27:12 +0000 Commit: Peter Grehan CommitDate: 2024-01-14 11:38:55 +0000 Fix issue with Linux guest XHCI tablet probing. The USB3 spec mandates that the device-descriptor max packet size be 512 bytes, which requires a field size of 9 since it is a power-of-2. Linux kernels recently started validating this field, resulting in the table not being probed and the cursor not working in bhyve VNC. Reviewed by: corvink PR: 275760 MFC after: 1 week --- usr.sbin/bhyve/usb_mouse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/usb_mouse.c b/usr.sbin/bhyve/usb_mouse.c index 80f79980a98e..a37941c0cd9d 100644 --- a/usr.sbin/bhyve/usb_mouse.c +++ b/usr.sbin/bhyve/usb_mouse.c @@ -154,7 +154,7 @@ static struct usb_device_descriptor umouse_dev_desc = { .bLength = sizeof(umouse_dev_desc), .bDescriptorType = UDESC_DEVICE, MSETW(.bcdUSB, UD_USB_3_0), - .bMaxPacketSize = 8, /* max packet size */ + .bMaxPacketSize = 9, /* max pkt size, 2^9 = 512 */ MSETW(.idVendor, 0xFB5D), /* vendor */ MSETW(.idProduct, 0x0001), /* product */ MSETW(.bcdDevice, 0), /* device version */