From nobody Thu Jan 27 16:13:10 2022
X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2B040198F0EF;
Thu, 27 Jan 2022 16:13:13 +0000 (UTC)
(envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (glebi.us [162.251.186.162])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
client-signature RSA-PSS (2048 bits) client-digest SHA256)
(Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
by mx1.freebsd.org (Postfix) with ESMTPS id 4Jl5Gw4qdHz3PdQ;
Thu, 27 Jan 2022 16:13:12 +0000 (UTC)
(envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 20RGDA0l048988
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
Thu, 27 Jan 2022 08:13:10 -0800 (PST)
(envelope-from glebius@freebsd.org)
Received: (from glebius@localhost)
by cell.glebi.us (8.16.1/8.16.1/Submit) id 20RGDAcL048987;
Thu, 27 Jan 2022 08:13:10 -0800 (PST)
(envelope-from glebius@freebsd.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f
Date: Thu, 27 Jan 2022 08:13:10 -0800
From: Gleb Smirnoff <glebius@freebsd.org>
To: Hans Petter Selasky <hps@selasky.org>
Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org,
dev-commits-src-main@freebsd.org
Subject: Re: git: 17cbcf33c3b6 - main - mbuf(9): Assert receive mbufs don't
carry a send tag.
Message-ID: <YfLElqsV3yKSBb8L@FreeBSD.org>
References: <202201261242.20QCg8jX074972@gitrepo.freebsd.org>
<YfIqmPWq09gz1AWJ@FreeBSD.org>
<e45bfc10-c56c-ee1a-8b92-0be1a8d8ed17@selasky.org>
List-Id: Commit messages for the main branch of the src repository <dev-commits-src-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main
List-Help: <mailto:dev-commits-src-main+help@freebsd.org>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-main@freebsd.org
X-BeenThere: dev-commits-src-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e45bfc10-c56c-ee1a-8b92-0be1a8d8ed17@selasky.org>
X-Rspamd-Queue-Id: 4Jl5Gw4qdHz3PdQ
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
none
X-Spamd-Result: default: False [-4.00 / 15.00];
REPLY(-4.00)[]
X-ThisMailContainsUnwantedMimeParts: N
On Thu, Jan 27, 2022 at 09:29:51AM +0100, Hans Petter Selasky wrote:
H> On 1/27/22 06:16, Gleb Smirnoff wrote:
H> > Why do you allow (m == NULL) in the assertion? Does it make any sense to
H> > relax it this way?
H>
H> Because the other M_XXXX assert macros checked for NULL aswell.
M_ASSERTPKTHDR() does absolutely the opposite - it asserts that m is present.
M_ASSERTEXTPG() doesn't check that explicitly, but also disallows (m == NULL).
--
Gleb Smirnoff