From owner-cvs-all  Fri Oct 19 18:39:34 2001
Delivered-To: cvs-all@freebsd.org
Received: from femail45.sdc1.sfba.home.com (femail45.sdc1.sfba.home.com [24.254.60.39])
	by hub.freebsd.org (Postfix) with ESMTP
	id 44C7C37B407; Fri, 19 Oct 2001 18:39:31 -0700 (PDT)
Received: from laptop.baldwin.cx ([24.2.39.156])
          by femail45.sdc1.sfba.home.com
          (InterMail vM.4.01.03.20 201-229-121-120-20010223) with ESMTP
          id <20011020013929.YXHU16716.femail45.sdc1.sfba.home.com@laptop.baldwin.cx>;
          Fri, 19 Oct 2001 18:39:29 -0700
Message-ID: <XFMail.011019183923.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200110200122.f9K1Mgk29798@freefall.freebsd.org>
Date: Fri, 19 Oct 2001 18:39:23 -0700 (PDT)
From: John Baldwin <jhb@FreeBSD.org>
To: John Baldwin <jhb@FreeBSD.org>
Subject: RE: cvs commit: src/sys/kern kern_mutex.c kern_sx.c
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


On 20-Oct-01 John Baldwin wrote:
> jhb         2001/10/19 18:22:42 PDT
> 
>   Modified files:
>     sys/kern             kern_mutex.c kern_sx.c 
>   Log:
>   The mtx_init() and sx_init() functions bzero'd locks before handing them
>   off to witness_init() making the check for double intializating a lock by
>   testing the LO_INITIALIZED flag moot.  Workaround this by checking the
>   LO_INITIALIZED flag ourself before we bzero the lock structure.

This has only been tested on x86 and alpha.  If you get a panic with this
during early boot, it may be b/c 0xdeadc0de has LO_INITIALIZED set in it. :) 
In that case, you will want to malloc() your mutexes with M_ZERO similar to
some changes I checked in last week.  If it's after boot, it may be a
legitimate bug, in which case traces and KTR logs may be your best help in
figuring out what is going on.

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message