From owner-svn-ports-all@freebsd.org Thu Aug 18 04:19:35 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 125F3BBDDBD; Thu, 18 Aug 2016 04:19:35 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 0853B1238; Thu, 18 Aug 2016 04:19:35 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 071C8109B; Thu, 18 Aug 2016 04:19:35 +0000 (UTC) Date: Thu, 18 Aug 2016 04:19:35 +0000 From: Alexey Dokuchaev To: Tilman Keskinoz Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420373 - in head/www: . wt wt/files Message-ID: <20160818041934.GA81349@FreeBSD.org> References: <201608172119.u7HLJg6w021760@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201608172119.u7HLJg6w021760@repo.freebsd.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2016 04:19:35 -0000 On Wed, Aug 17, 2016 at 09:19:42PM +0000, Tilman Keskinoz wrote: > New Revision: 420373 > URL: https://svnweb.freebsd.org/changeset/ports/420373 > > Log: > Add Wt, a C++ library for developing web applications. > PR: 210750 > Submitted by: Mohammad S. Babaei It should've been reviewed better prior to committing, at a quick glance: > [...] > @@ -0,0 +1,299 @@ > +# Created by: Mohammad S. Babaei > +# $FreeBSD$ > + > +PORTNAME= wt > +PORTVERSION= 3.3.6 > +CATEGORIES= www > +MASTER_SITES= https://github.com/${GH_ACCOUNT}/${PORTNAME}/archive/${PORTVERSION}/ \ > + http://github.com/${GH_ACCOUNT}/${PORTNAME}/archive/${PORTVERSION}/ Typically MASTER_SITES are not needed if USE_GITHUB and GH_* knobs are set correctly. > +GH_ACCOUNT= kdeforche Hm, but where is USE_GITHUB=yes? > +OPTIONS_DEFAULT= \ > + DOCS \ > + EXAMPLES \ Both DOCS and EXAMPLES are enabled by default and should not be listed here. > +DOCS_DESC= Build and/or install documentation Useless line, DOCS_DESC is preset to this value. > +CMAKE_MODULE_DESC= Install FindWt.cmake in systemwide cmake dir (in addition to CMAKE_INSTALL_PREFIX/cmake) Very long option description (others as well). It's impossible to read it and thus understand even in full-screen xterm(1). > +CPP11_DESC= Compile Wt in C++11 mode (Clang or GCC 4.6+) > +HARU_DESC= Enable Haru Free PDF Library, which is used to provide support for painting to PDF (WPdfImage) > +PANGO_DESC= Enable Pango Library, which is used for improved font support (WPdfImage and WRasterImage) > +EXT_DESC= Build Wt Ext library with JavaScript-only widgets (http://extjs.com/) DEPRECATED > +QT4_DESC= Build Qt4 interworking library (libwtwithqt) > +LIBWTTEST_DESC= Build Wt::Test for automated (integration/unit) tests > +OPENGL_DESC= Build Wt with support for server-side opengl rendering Overly verbose descriptions. Consider shorting them and providing pkg-help if you really think that elaborate explanation is needed. "Pango Library" and "opengl" are badly spelled. Starting descriptions with "Enable ..." is discouraged as well. > +USE_LDCONFIG= yes > +USES= cmake:outsource pkgconfig ssl > +USE_XORG+=x11 Missorted USES/USE_* knobs > +MAKE_JOBS_SAFE= yes This is the default for quite a long time. > +.if ${PORT_OPTIONS:MDOCS} > +BUILD_DEPENDS+= asciidoc:textproc/asciidoc \ > + doxygen:devel/doxygen > +CMAKE_ARGS+= -DBUILD_DOCS:BOOL=ON > +.else > +CMAKE_ARGS+= -DBUILD_DOCS:BOOL=OFF > +.endif Consider using option helpers (here and below). ./danfe