From owner-svn-ports-head@freebsd.org Sun Oct 6 08:11:20 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 12E21130D87; Sun, 6 Oct 2019 08:11:20 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46mGXR6Z1tz3JfR; Sun, 6 Oct 2019 08:11:19 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 57B51206FC; Sun, 6 Oct 2019 04:11:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 06 Oct 2019 04:11:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=iNwFUw M0TuqgBZwkWB3apPtdAjXeePi3kiamz+JaqnQ=; b=zXzJEmB3q/gutV9GDfgtn2 7WkGwKrFIatca+vyhGh7Vdp/31y3ckmUwAbaw47IVoN6PUARExS4VNpUq/CQ9Aod cVQjtDW46+i5gh7fWet3VQwLBbp/NDkB2NuktjML69y54S972M+v9IMlK/VyhkU5 0tst4CvRJpEvy3v2eQNJYCbXT5BDpuY2X0qRRVC3X0DPiMvp8lIaeXQoB4x8yam7 H+WLc8oX/jRkHHIPWjsbOiigMZNMWGwqoD97ZNUKML2BTk6ivgHQXlQPa6l3mlk5 oGZD4RQGwDk83dUUqIQgtrBpwbOP78qDupYk8MJx0TcBqybj1kb3IQHMWsUU80dg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrheehgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesghdtre ertdervdenucfhrhhomhepvfhosghirghsucfmohhrthhkrghmphcuoehtohgsihhksehf rhgvvggsshgurdhorhhgqeenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucfkph epleehrdeltddrvddviedruddunecurfgrrhgrmhepmhgrihhlfhhrohhmpehtohgsihhk sehfrhgvvggsshgurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from urd.tobik.me (ip5f5ae20b.dynamic.kabel-deutschland.de [95.90.226.11]) by mail.messagingengine.com (Postfix) with ESMTPA id 8EFB680059; Sun, 6 Oct 2019 04:11:16 -0400 (EDT) Date: Sun, 6 Oct 2019 10:11:14 +0200 From: Tobias Kortkamp To: Gleb Popov Cc: Mikhail Teterin , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r513679 - head/sysutils/fusefs-smbnetfs/files Message-ID: <20191006081114.GA33887@urd.tobik.me> References: <201910031745.x93Hje5x059120@repo.freebsd.org> <20191006054444.GB62549@urd.tobik.me> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 46mGXR6Z1tz3JfR X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Oct 2019 08:11:20 -0000 --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 06, 2019 at 11:59:10AM +0400, Gleb Popov wrote: > On Sun, Oct 6, 2019 at 9:44 AM Tobias Kortkamp wrote: >=20 > > On Thu, Oct 03, 2019 at 05:45:40PM +0000, Mikhail Teterin wrote: > > > Author: mi > > > Date: Thu Oct 3 17:45:39 2019 > > > New Revision: 513679 > > > URL: https://svnweb.freebsd.org/changeset/ports/513679 > > > > > > Log: > > > Add a patch from upstream, fixing the author's typo in an option's > > name. > > > It only affects users of libsecret, which is off by default -- thus= no > > > port-revision bump. > > > > That's not a valid reason not to bump PORTREVISION. Please bump > > it so that users how happen to build it with LIBSECRET=3Don get your > > fix automatically. > > >=20 > I have been told that PORTREVISION should be bumped whenever output packa= ge > changes. It isn't the case here. Or am I mistaken? We do not have options specific PORTREVISIONs and there are more package repositories than pkg.FreeBSD.org. If you have previously built your packages with LIBSECRET=3Don, the applied fix will change the package in a non-trivial way. However since PORTREVISION was not bumped Poudriere or other package builders will not rebuild the package. Bascially people will have to micromanage/force the rebuild fusefs-smbnetfs if they want this fix. fusefs-smbnetfs is hardly an expensive package to build so saving rebuilds at the cost of wasting people's time is not worth it and bad UX. --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl2ZoaBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2HoGAf+JO+PUjXZz1QboAzSlnzvK1AJwVrp8SKYEtqXVZllTtlzw93X01SVym02 T9szhFLJz8KGin9Clmcv/a5wgFxzkoyUJIXPX5iJKDhtVUt+apig7123OH0kQzJ9 +q2VLBkvCGmQjkS5US3cwwEmHchCeWPXsp6l8K9vg8qxPcGo8aZL+r0iMyyIaqLP SH9Ocr8TdNBDhM+9F6Fz5khKes6xnoV+YjyFJbuYPRtObqVW+pDx4W7Rw6Daca/Y Z0GUn2hURJ6YeQ05r5kr6zMo4eQafIB2HmBSq1EJ1eTkLLF6SaKd33tGfiBO+pha bdTxBdTAxjVO9XUwdJx0sMedxemwMg== =qUph -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--