From owner-freebsd-hackers@freebsd.org Wed Feb 3 19:17:40 2021 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 91ABD5289C0 for ; Wed, 3 Feb 2021 19:17:40 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DWBK03rWHz3MFB; Wed, 3 Feb 2021 19:17:40 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (unknown [98.42.164.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 0C20036AB5; Wed, 3 Feb 2021 19:17:39 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.45.21011103 Date: Wed, 03 Feb 2021 11:17:37 -0800 Subject: Re: Including IB utils in install images From: Ravi Pokala To: Glen Barber CC: "freebsd-hackers@freebsd.org" Message-ID: <383934FB-B779-42CD-8F91-2F1786B7DB02@panasas.com> Thread-Topic: Including IB utils in install images Thread-Index: AQHW+lw4Axie7eybUkG6T4Z4Be/d+A== References: <377FA5D1-0DC8-463D-A8E3-5645801C2858@freebsd.org> <20210203182928.GG77557@FreeBSD.org> In-Reply-To: <20210203182928.GG77557@FreeBSD.org> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Technical discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2021 19:17:40 -0000 -----Original Message----- From: Glen Barber Date: 2021-02-03, Wednesday at 10:29 To: Ravi Pokala Cc: "freebsd-hackers@freebsd.org" Subject: Re: Including IB utils in install images On Wed, Feb 03, 2021 at 10:06:20AM -0800, Ravi Pokala wrote: > Hi folks, > > I'm using release/release.sh to create install images. We recently determined that we need to start including the InfiniBand utilities (contrib/ofed/infiniband-diags / usr.bin/ofed/infiniband-diags). I updated my release.conf to add 'WITH_OFED_EXTRA=1' to MAKE_FLAGS, and I confirmed that the utilities are being built. However, they are not subsequently copied to the distdir, or included in the resulting image. Well, technically, `ibstat' is, but per usr.bin/ofed/infiniband-diags/Makefile, it is not contingent on WITH_OFED_EXTRA / MK_OFED_EXTRA. > > Bug, or operator error? > Hi Glen, You could set a local SRC_CONF (see release/release.conf.sample), but I *think* you also need to set WITH_OFED=1. According to src.conf(5), it seems WITH_OFED_EXTRA is ignored unless WITH_OFED is explicitly set. While that's certainly logical, src.conf(5) does not actually contain that wording. But it's moot; OFED is already in __DEFAULT_YES_OPTIONS in src.opts.mk, so WITH_OFED=1 is implied. Looking for what's happening with `ibstat' (outside MK_OFED_EXTRA) and `ibping' (inside MK_OFED_EXTRA), this is what I see: ================================================================ [builder:/usr0/rpokala] rpokala> egrep '^===> .*/(ibstat|ibping)' release.out ===> usr.bin/ofed/infiniband-diags/ibstat (cleandir) ===> usr.bin/ofed/infiniband-diags/ibping (cleandir) ===> usr.bin/ofed/infiniband-diags/ibstat (cleandir) ===> usr.bin/ofed/infiniband-diags/ibping (cleandir) ===> usr.bin/ofed/infiniband-diags/ibstat (includes) ===> usr.bin/ofed/infiniband-diags/ibping (includes) ===> usr.bin/ofed/infiniband-diags/ibstat (all) ===> usr.bin/ofed/infiniband-diags/ibping (all) ===> usr.bin/ofed/infiniband-diags/ibstat (install) ===> usr.bin/ofed/infiniband-diags/ibstat (installconfig) ===> usr.bin/ofed/infiniband-diags/ibstat (cleandir) ===> usr.bin/ofed/infiniband-diags/ibping (cleandir) ===> usr.bin/ofed/infiniband-diags/ibstat (cleandir) ===> usr.bin/ofed/infiniband-diags/ibping (cleandir) ===> usr.bin/ofed/infiniband-diags/ibstat (includes) ===> usr.bin/ofed/infiniband-diags/ibping (includes) ===> usr.bin/ofed/infiniband-diags/ibstat (all) ===> usr.bin/ofed/infiniband-diags/ibping (all) ===> usr.bin/ofed/infiniband-diags/ibstat (distribute) ===> usr.bin/ofed/infiniband-diags/ibstat (installconfig) ===> usr.bin/ofed/infiniband-diags/ibstat (install) ===> usr.bin/ofed/infiniband-diags/ibstat (installconfig) ===> usr.bin/ofed/infiniband-diags/ibstat (install) ===> usr.bin/ofed/infiniband-diags/ibstat (installconfig) ===> usr.bin/ofed/infiniband-diags/ibstat (install) ===> usr.bin/ofed/infiniband-diags/ibstat (installconfig) ================================================================ Note that both are part of "cleandir", "includes", and "all", but only `ibstat' is part of "install", "installconfig", and "distribute". I have no idea how things get onto those lists, but it appears that that's not happening in the MK_OFED_EXTRA case. Thanks, Ravi (rpokala@) Glen