From owner-freebsd-embedded@FreeBSD.ORG Fri Dec 23 15:31:41 2011 Return-Path: Delivered-To: embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B0696106564A for ; Fri, 23 Dec 2011 15:31:41 +0000 (UTC) (envelope-from ray@freebsd.org) Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146]) by mx1.freebsd.org (Postfix) with ESMTP id 6AAFC8FC0C for ; Fri, 23 Dec 2011 15:31:41 +0000 (UTC) Received: from rnote.ddteam.net (11-119-133-95.pool.ukrtel.net [95.133.119.11]) (Authenticated sender: ray) by smtp.dlink.ua (Postfix) with ESMTPSA id 4BFBAC4930; Fri, 23 Dec 2011 17:31:40 +0200 (EET) Date: Fri, 23 Dec 2011 17:31:39 +0200 From: Aleksandr Rybalko To: Stefan Bethke Message-Id: <20111223173139.dd31e9cb.ray@freebsd.org> In-Reply-To: <1C7BEB2A-E3DE-4AB0-BC57-AC0025116EF0@lassitu.de> References: <20111223122947.4235c390.ray@freebsd.org> <1C7BEB2A-E3DE-4AB0-BC57-AC0025116EF0@lassitu.de> Organization: FreeBSD.ORG X-Mailer: Sylpheed 3.1.2 (GTK+ 2.24.5; amd64-portbld-freebsd9.0) X-Operating-System: FreeBSD Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: embedded@freebsd.org Subject: Re: geom_uncompress X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2011 15:31:41 -0000 On Fri, 23 Dec 2011 13:05:09 +0100 Stefan Bethke wrote: > Very cool! > > Am 23.12.2011 um 11:29 schrieb Aleksandr Rybalko: > > > http://my.ddteam.net/files/geom_uncompress_2011-12-23_2.patch > > In your original patch in February 2010, you supported only lzma. In > this version, your module supports both zlib and lzma compression. > Wouldn't it make more sense to replace geom_uzip, and integrate > mkuzip and mklzma into a single utility? Agree, but this is for future. > > I also faintly remember some bike shed about the original geom_uzip > name. Yes, I also remember that, finally we decide to use short but unambiguous name. geom_uncompress from that point. :) > > The magic header definition should likely be in a common file, shared > between the utility(s) and the geom module(s). As you mentioning first, better to have both in one utility. Even better to include bzip2 in same utility. > > And a final nitpick: we really don't have a suitable crc32 function > in the kernel already? I don't have a plans to rewrite and embed lzma code to base. There is the way to use external crc32 in xz-embedded, but it also take some time. And crc code not so big even for embedded purposes. Anyway I agree with you in that question too. > > > Stefan > > -- > Stefan Bethke Fon +49 151 14070811 > > > Thank you for comments/questions Stefan. WBW -- Aleksandr Rybalko