Date: Thu, 8 Feb 2024 17:01:04 GMT From: Gleb Smirnoff <glebius@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 45eae45d91cb - main - tests/unix_passfd: fix typos - assignment instead of comparison Message-ID: <202402081701.418H14q8065681@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=45eae45d91cb308396e15d6dabc764fc4c701f9f commit 45eae45d91cb308396e15d6dabc764fc4c701f9f Author: Gleb Smirnoff <glebius@FreeBSD.org> AuthorDate: 2024-02-08 17:00:23 +0000 Commit: Gleb Smirnoff <glebius@FreeBSD.org> CommitDate: 2024-02-08 17:00:37 +0000 tests/unix_passfd: fix typos - assignment instead of comparison This typos were actually hiding a kernel bug, see 541e6a989cae. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D43734 --- tests/sys/kern/unix_passfd_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/sys/kern/unix_passfd_test.c b/tests/sys/kern/unix_passfd_test.c index 9c9a6a175ceb..67171e62c963 100644 --- a/tests/sys/kern/unix_passfd_test.c +++ b/tests/sys/kern/unix_passfd_test.c @@ -912,7 +912,7 @@ ATF_TC_BODY(empty_rights_message, tc) /* Only the non-empty message should be received. */ len = recvmsg(fd[1], &msghdr, 0); ATF_REQUIRE_MSG(len == 0, "recvmsg failed: %s", strerror(errno)); - ATF_REQUIRE(msghdr.msg_controllen = CMSG_SPACE(sizeof(int))); + ATF_REQUIRE(msghdr.msg_controllen == CMSG_SPACE(sizeof(int))); error = close(*(int *)CMSG_DATA(msghdr.msg_control)); ATF_REQUIRE_MSG(error == 0, "close failed: %s", strerror(errno)); @@ -938,7 +938,7 @@ ATF_TC_BODY(empty_rights_message, tc) /* Only the non-empty message should be received. */ len = recvmsg(fd[1], &msghdr, 0); ATF_REQUIRE_MSG(len == 0, "recvmsg failed: %s", strerror(errno)); - ATF_REQUIRE(msghdr.msg_controllen = CMSG_SPACE(sizeof(int))); + ATF_REQUIRE(msghdr.msg_controllen == CMSG_SPACE(sizeof(int))); error = close(*(int *)CMSG_DATA(msghdr.msg_control)); ATF_REQUIRE_MSG(error == 0, "close failed: %s", strerror(errno));
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202402081701.418H14q8065681>