From owner-svn-src-head@freebsd.org Thu Nov 12 17:15:05 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74C1DA2C7DF; Thu, 12 Nov 2015 17:15:05 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2EF601648; Thu, 12 Nov 2015 17:15:04 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 5B30125D385E; Thu, 12 Nov 2015 17:15:02 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 8C4B5C770A6; Thu, 12 Nov 2015 17:15:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id pvp4KctF-pIX; Thu, 12 Nov 2015 17:15:00 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4420:cabc:c8ff:fe8b:4fe6] (orange-tun0-ula.sbone.de [IPv6:fde9:577b:c1a9:4420:cabc:c8ff:fe8b:4fe6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id D4BD1C76FE5; Thu, 12 Nov 2015 17:14:59 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r290714 - in head/sys/tests: callout_test framework From: "Bjoern A. Zeeb" In-Reply-To: <20151112171046.GN2257@kib.kiev.ua> Date: Thu, 12 Nov 2015 17:14:58 +0000 Cc: Randall Stewart , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <93751CDC-3F92-4087-AA6E-63F459F576D8@FreeBSD.org> References: <201511121031.tACAVEMb079802@repo.freebsd.org> <71CD11C2-1A0F-48B3-B9A9-B025676A887C@FreeBSD.org> <20151112171046.GN2257@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2015 17:15:05 -0000 > On 12 Nov 2015, at 17:10 , Konstantin Belousov = wrote: >=20 > On Thu, Nov 12, 2015 at 05:01:39PM +0000, Bjoern A. Zeeb wrote: >>=20 >>> On 12 Nov 2015, at 10:31 , Randall Stewart wrote: >>>=20 >>> Author: rrs >>> Date: Thu Nov 12 10:31:14 2015 >>> New Revision: 290714 >>> URL: https://svnweb.freebsd.org/changeset/base/290714 >>>=20 >>> Log: >>> Style 9 changes. >>> MFC after: 1 Month >>>=20 >>> Modified: >>> head/sys/tests/callout_test/callout_test.c >>> head/sys/tests/framework/kern_testfrwk.c >>=20 >>=20 >> I am just replying to the last commit given despite the efforts of = people it still fails on PC98: >>=20 >> = /scratch/tmp/bz/head.svn/sys/modules/tests/callout_test/../../../tests/cal= lout_test/callout_test.c:52:9: error: 'cpu_spinwait' macro redefined = [-Werror,-Wmacro-redefined] >> #define cpu_spinwait() >> ^ >> ./i386/cpu.h:50:9: note: previous definition is here >> #define cpu_spinwait() ia32_pause() >> ^ >> 1 error generated. >> --- callout_test.o --- >> *** [callout_test.o] Error code 1 >>=20 >> bmake: stopped in = /scratch/tmp/bz/head.svn/sys/modules/tests/callout_test >>=20 >=20 > Which version did you checked out ? I removed the redefinition of > the cpu_spinwait() for UP in r290707, and it was not reverted. Good, this was 705; must have missed your commit. Thanks! /bz=