Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 12 Nov 2015 17:14:58 +0000
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        Randall Stewart <rrs@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r290714 - in head/sys/tests: callout_test framework
Message-ID:  <93751CDC-3F92-4087-AA6E-63F459F576D8@FreeBSD.org>
In-Reply-To: <20151112171046.GN2257@kib.kiev.ua>
References:  <201511121031.tACAVEMb079802@repo.freebsd.org> <71CD11C2-1A0F-48B3-B9A9-B025676A887C@FreeBSD.org> <20151112171046.GN2257@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help

> On 12 Nov 2015, at 17:10 , Konstantin Belousov <kostikbel@gmail.com> =
wrote:
>=20
> On Thu, Nov 12, 2015 at 05:01:39PM +0000, Bjoern A. Zeeb wrote:
>>=20
>>> On 12 Nov 2015, at 10:31 , Randall Stewart <rrs@FreeBSD.org> wrote:
>>>=20
>>> Author: rrs
>>> Date: Thu Nov 12 10:31:14 2015
>>> New Revision: 290714
>>> URL: https://svnweb.freebsd.org/changeset/base/290714
>>>=20
>>> Log:
>>> Style 9 changes.
>>> MFC after:	1 Month
>>>=20
>>> Modified:
>>> head/sys/tests/callout_test/callout_test.c
>>> head/sys/tests/framework/kern_testfrwk.c
>>=20
>>=20
>> I am just replying to the last commit given despite the efforts of =
people it still fails on PC98:
>>=20
>> =
/scratch/tmp/bz/head.svn/sys/modules/tests/callout_test/../../../tests/cal=
lout_test/callout_test.c:52:9: error: 'cpu_spinwait' macro redefined =
[-Werror,-Wmacro-redefined]
>> #define cpu_spinwait()
>>        ^
>> ./i386/cpu.h:50:9: note: previous definition is here
>> #define cpu_spinwait()                  ia32_pause()
>>        ^
>> 1 error generated.
>> --- callout_test.o ---
>> *** [callout_test.o] Error code 1
>>=20
>> bmake: stopped in =
/scratch/tmp/bz/head.svn/sys/modules/tests/callout_test
>>=20
>=20
> Which version did you checked out ?  I removed the redefinition of
> the cpu_spinwait() for UP in r290707, and it was not reverted.


Good, this was 705;  must have missed your commit.  Thanks!

/bz=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?93751CDC-3F92-4087-AA6E-63F459F576D8>