From owner-p4-projects@FreeBSD.ORG  Thu Apr 12 13:58:03 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B755D16A406; Thu, 12 Apr 2007 13:58:03 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 73A4516A404
	for <perforce@freebsd.org>; Thu, 12 Apr 2007 13:58:03 +0000 (UTC)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 606BB13C4C1
	for <perforce@freebsd.org>; Thu, 12 Apr 2007 13:58:03 +0000 (UTC)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3CDw359013872
	for <perforce@freebsd.org>; Thu, 12 Apr 2007 13:58:03 GMT
	(envelope-from csjp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3CDw2AT013869
	for perforce@freebsd.org; Thu, 12 Apr 2007 13:58:02 GMT
	(envelope-from csjp@freebsd.org)
Date: Thu, 12 Apr 2007 13:58:02 GMT
Message-Id: <200704121358.l3CDw2AT013869@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	csjp@freebsd.org using -f
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 117965 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Apr 2007 13:58:04 -0000

http://perforce.freebsd.org/chv.cgi?CH=117965

Change 117965 by csjp@csjp_push on 2007/04/12 13:57:46

	Add some bzero()s to ensure that we are proerly clearing any old data.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/security/audit/audit_syscalls.c#31 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/security/audit/audit_syscalls.c#31 (text+ko) ====

@@ -534,6 +534,7 @@
 		PROC_UNLOCK(td->td_proc);
 		return (E2BIG);
 	}
+	bzero(&ai, sizeof(ai));
 	ai.ai_auid = td->td_proc->p_au->ai_auid;
 	ai.ai_mask = td->td_proc->p_au->ai_mask;
 	ai.ai_asid = td->td_proc->p_au->ai_asid;
@@ -573,6 +574,7 @@
 	 * XXXRW: Test privilege while holding the proc lock?
 	*/
 	PROC_LOCK(td->td_proc);
+	bzero(td->td_proc->p_au, sizeof(struct auditinfo_addr));
 	td->td_proc->p_au->ai_auid = ai.ai_auid;
 	td->td_proc->p_au->ai_mask = ai.ai_mask;
 	td->td_proc->p_au->ai_asid = ai.ai_asid;