Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Jan 2011 18:31:57 +0000 (UTC)
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r217700 - in stable/8/sys/amd64: ia32 linux32
Message-ID:  <201101211831.p0LIVvYQ063449@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jkim
Date: Fri Jan 21 18:31:57 2011
New Revision: 217700
URL: http://svn.freebsd.org/changeset/base/217700

Log:
  MFC:	r217424
  
  Remove redundant, bogus, and even harmful uses of setting TS bit in CR0.
  It is done from fpstate_drop() when it is really necessary.

Modified:
  stable/8/sys/amd64/ia32/ia32_signal.c
  stable/8/sys/amd64/linux32/linux32_sysvec.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)

Modified: stable/8/sys/amd64/ia32/ia32_signal.c
==============================================================================
--- stable/8/sys/amd64/ia32/ia32_signal.c	Fri Jan 21 18:18:55 2011	(r217699)
+++ stable/8/sys/amd64/ia32/ia32_signal.c	Fri Jan 21 18:31:57 2011	(r217700)
@@ -741,7 +741,6 @@ ia32_setregs(td, entry, stack, ps_string
 	regs->tf_gs = _ugssel;
 	regs->tf_flags = TF_HASSEGS;
 
-	load_cr0(rcr0() | CR0_MP | CR0_TS);
 	fpstate_drop(td);
 
 	/* Return via doreti so that we can change to a different %cs */

Modified: stable/8/sys/amd64/linux32/linux32_sysvec.c
==============================================================================
--- stable/8/sys/amd64/linux32/linux32_sysvec.c	Fri Jan 21 18:18:55 2011	(r217699)
+++ stable/8/sys/amd64/linux32/linux32_sysvec.c	Fri Jan 21 18:31:57 2011	(r217700)
@@ -875,7 +875,7 @@ exec_linux_setregs(td, entry, stack, ps_
 	regs->tf_flags = TF_HASSEGS;
 	regs->tf_cs = _ucode32sel;
 	regs->tf_rbx = ps_strings;
-	load_cr0(rcr0() | CR0_MP | CR0_TS);
+
 	fpstate_drop(td);
 
 	/* Do full restore on return so that we can change to a different %cs */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101211831.p0LIVvYQ063449>