Date: Thu, 26 Feb 2004 21:06:21 -0500 From: Garance A Drosihn <drosih@rpi.edu> To: Kris Kennaway <kris@obsecurity.org> Cc: John Polstra <jdp@polstra.com> Subject: Re: 64btt cvsup? Message-ID: <p0602048ebc64527a8038@[128.113.24.47]> In-Reply-To: <20040226051055.GA85017@xor.obsecurity.org> References: <XFMail.20040224164527.jdp@polstra.com> <p06020489bc632640222e@[128.113.24.47]> <20040226051055.GA85017@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 9:10 PM -0800 2/25/04, Kris Kennaway wrote: >On Thu, Feb 26, 2004, Garance A Drosihn wrote: > > > John wrote: > > > Figure out the ports-Makefile-fu to make the new patches > > > get applied only if the system has a recent enough > > > __FreeBSD_version. That ought to do it. > > >> I have no idea what ports-makefile-fu would be needed, but we >> haven't picked the value of __FreeBSD_version for this change yet, >> so I have the excuse that we couldn't really do this yet anyway. > >Ports don't usually apply patches conditionally on the version. >Instead, wherever possible the patch itself should contain the >conditionals, i.e. > >#if __FreeBSD_version >= 50210x >... >#endif Okay, after mulling over various comments, I came with the patch that's in: It is at: http://people.freebsd.org/~gad/time-64/port-ezm3.diff This is a patch to the port itself. Ie, you can: cd /usr/ports/lang/ezm3 patch -p0 < /tmp/port-ezm3.diff and do something like 'make patch'. This does not depend on __FreeBSD_version, and it should automatically detect whether ezm3 should be built for 32-bit or 64-bit time_t. This is done by adding an "extra patch" to the port, so it is determined at patch time, instead of at the (more desirable) build-time. It also prints out an informational message (in a pre-patch target) indicating which time_t ezm3 is being built for. These changes will only effect builds done on sparc64. I do not know who the proper person would be to do the actual commit of this, but I'm pretty sure it is not me! I can say that I have checked it, and it does work the way I wanted it to. Due to the way it works, it could be committed right now. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p0602048ebc64527a8038>