From owner-freebsd-current@FreeBSD.ORG Sun Mar 22 22:19:25 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0171E820; Sun, 22 Mar 2015 22:19:24 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 74C41EBE; Sun, 22 Mar 2015 22:19:24 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::b11b:b36a:c2e8:f12e] (unknown [IPv6:2001:7b8:3a7:0:b11b:b36a:c2e8:f12e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id A0C745C4D; Sun, 22 Mar 2015 23:19:21 +0100 (CET) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_A2E23188-C424-494C-B941-7BF4A9BACA97"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: Date: Sun, 22 Mar 2015 23:19:20 +0100 Message-Id: References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> <08BB20A2-7B71-4ECF-B246-F3096CABA5E9@gmail.com> <72ABF177-320F-4CB1-8B05-36B133714C55@FreeBSD.org> To: Garrett Cooper X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 22:19:25 -0000 --Apple-Mail=_A2E23188-C424-494C-B941-7BF4A9BACA97 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 22 Mar 2015, at 23:11, Garrett Cooper wrote: >=20 > On Mar 22, 2015, at 15:09, Dimitry Andric wrote: >=20 >> On 22 Mar 2015, at 23:04, Garrett Cooper = wrote: >>>=20 >>> On Mar 22, 2015, at 15:01, Craig Rodrigues = wrote: >>>=20 >>> ... >>>=20 >>>> OK, converting expr.y to use unsigned integers would require a bit = of work. >>>>=20 >>>> Can you commit your patch to the Makefile? It fixes the problem = for now. >>>=20 >>> +1 >>>=20 >>> I=92d still like to know why clang 3.5 doesn=92t have this behavior = though =97 there might be other potential issues lurking around that = need to be solved (either here, in ports, or both). >>=20 >> Because this version optimizes better around undefined behavior. = There >> are most likely many issues lurking around, and most certainly in = ports. >>=20 >> I would recommend using UBSan to tackle this kind of thing. >=20 > I hope this got a ports tinderbox run first=85 It is called an "exp-run" in ports land, but that only really tests whether ports *build* successfully. For most ports, there is no good way of testing them, certainly not if they don't have their own testing facilities. That said, I have built quite a number of ports with 3.6.0, even before the import, and saw zero problems until now. Then again, I'm just one user, and that is a very low sample size. ;) I don't expect a great many problems with integer wrapping though. You have to realize that quite a lot of open source projects already went through this phase, when gcc started optimizing integer wrapping a few years ago. We are just slowly catching up. > Adding UBSan to tinderbox runs for toolchain upgrades [in the future] = might be a good idea. Maybe, but please note that both ASan and UBSan are still beta-ish under FreeBSD, there will most likely be bumps along the road. Any bug reports in that area are welcome. -Dimitry --Apple-Mail=_A2E23188-C424-494C-B941-7BF4A9BACA97 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlUPP+gACgkQsF6jCi4glqNNQgCdEyuU258imuu7h+koQkg2q/B0 SWEAmwaAd9VLhiRiz2+5Th9OyPxyxlGO =lsge -----END PGP SIGNATURE----- --Apple-Mail=_A2E23188-C424-494C-B941-7BF4A9BACA97--