From owner-cvs-all@FreeBSD.ORG Thu Dec 29 05:58:39 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0DEF416A41F; Thu, 29 Dec 2005 05:58:39 +0000 (GMT) (envelope-from mezz7@cox.net) Received: from centrmmtao04.cox.net (centrmmtao04.cox.net [70.168.83.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E40743D5C; Thu, 29 Dec 2005 05:58:38 +0000 (GMT) (envelope-from mezz7@cox.net) Received: from mezz.mezzweb.com ([68.103.32.140]) by centrmmtao04.cox.net (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP id <20051229055626.XVPC8318.centrmmtao04.cox.net@mezz.mezzweb.com>; Thu, 29 Dec 2005 00:56:26 -0500 Date: Wed, 28 Dec 2005 23:59:39 -0600 To: "Edwin Groothuis" References: <200512290138.jBT1cREu093693@repoman.freebsd.org> <20051229054645.GG3805@k7.mavetju> From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID: In-Reply-To: <20051229054645.GG3805@k7.mavetju> User-Agent: Opera M2/8.51 (Linux, build 1462) Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/graphics/librsvg2 Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Dec 2005 05:58:39 -0000 On Wed, 28 Dec 2005 23:46:45 -0600, Edwin Groothuis wrote: > On Wed, Dec 28, 2005 at 11:40:19PM -0600, Jeremy Messenger wrote: >> On Wed, 28 Dec 2005 19:38:27 -0600, Edwin Groothuis >> wrote: >> >> >edwin 2005-12-29 01:38:27 UTC >> > >> > FreeBSD ports repository >> > >> > Modified files: >> > graphics/librsvg2 Makefile >> > Log: >> > [PATCH] allows graphics/librsvg2 to build on 4.11 >> > patch allows graphics/librsvg2 to build on 4.11 >> > by disabling MOZILLA_PLUGIN option for >> > FreeBSD < 5.0 >> > PR: ports/90410 >> > Submitted by: Michael C. Shultz >> > Approved by: maintainer timeout >> >> If you want to do the maintainer timeout, can you please test it first >> before you commit it? Now it broke the build. I backed out to Makefile,v >> 1.48 by myself and I can build it again. > > [..] > ==> Compressing manual pages for librsvg2-2.12.7_3 > ===> Running ldconfig > /sbin/ldconfig -m /usr/X11R6/lib > ===> Registering installation for librsvg2-2.12.7_3 > ===> Building package for librsvg2-2.12.7_3 > Creating package /tmp/packages/All/librsvg2-2.12.7_3.tgz > Registering depends: libgsf-1.13.3 gtk-engines2-2.6.6_1 gconf2-2.12.1 > gtk-2.8.9 atk-1.10.3 pango-1.10.2 gnomehier-2.0_7 > XFree86-fontScalable-4.5.0 ORBit2-2.12.4_1 hicolor-icon-theme-0.5 > libIDL-0.8.6_1 libcroco-0.6.0_2 bitstream-vera-1.10_2 libXft-2.1.7 > cairo-1.0.2_1 XFree86-fontEncodings-4.5.0 linc-1.0.3_4 tiff-3.7.4 > shared-mime-info-0.16_2 XFree86-libraries-4.5.0 libart_lgpl2-2.3.17 > popt-1.7 fontconfig-2.3.2,1 libxml2-2.6.22 glib-2.8.4 gettext-0.14.5 > freetype2-2.1.10_2 pkgconfig-0.20 png-1.2.8_2 libiconv-1.9.2_1 > expat-1.95.8_3 jpeg-6b_3. > Creating gzip'd tar ball in '/tmp/packages/All/librsvg2-2.12.7_3.tgz' > > Please give me some more information as which OS version and friends. 6.0-STABLE, looks like this new change is causing mozilla plugins to be always enable. This part below is in the wrong place. CONFIGURE_ARGS+=--enable-mozilla-plugin=no Before: ================================== # make configure ===> Extracting for librsvg2-2.12.7_2 => MD5 Checksum OK for gnome2/librsvg-2.12.7.tar.bz2. [...] Build GdkPixbuf loader: yes Build theme engine: yes Build Netscape plugin: no <-- here. ================================== After: ================================== # make configure ===> Extracting for librsvg2-2.12.7_3 => MD5 Checksum OK for gnome2/librsvg-2.12.7.tar.bz2. [...] Build GdkPixbuf loader: yes Build theme engine: yes Build Netscape plugin: yes <-- here, even there is no mozilla dependency in the 'make depends'. ================================== I think, the mozilla plugins might be complete broke or maybe not. I haven't dig in it yet. Really, I don't see there is any point to have this plugins option when Mozilla/Firefox have their own SVG stuff thought. Maybe I am missing something for understand why librsvg has plugins option. Cheers, Mezz > Edwin -- mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org