From owner-cvs-all@FreeBSD.ORG Fri Dec 17 20:58:37 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3D911065673 for ; Fri, 17 Dec 2010 20:58:37 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx23.fluidhosting.com [204.14.89.6]) by mx1.freebsd.org (Postfix) with ESMTP id 1F5C18FC1B for ; Fri, 17 Dec 2010 20:58:36 +0000 (UTC) Received: (qmail 29557 invoked by uid 399); 17 Dec 2010 20:58:36 -0000 Received: from localhost (HELO doug-optiplex.ka9q.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 17 Dec 2010 20:58:36 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4D0BCEFA.1030305@FreeBSD.org> Date: Fri, 17 Dec 2010 12:58:34 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20101210 Thunderbird/3.1.7 MIME-Version: 1.0 To: "Philip M. Gollucci" References: <201012152244.oBFMigGD066775@repoman.freebsd.org> In-Reply-To: <201012152244.oBFMigGD066775@repoman.freebsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: janos.mohacsi@bsd.hu, cvs-ports@FreeBSD.org, Craig Leres , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/beacon Makefile ports/net/beacon/files beacon.in patch-Makefile.in patch-common-beacon.patch patch-libbeacon-Makefile.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2010 20:58:37 -0000 Couple of problems with this script. First, since by default it is now running as a non-root user it should REQUIRE: LOGIN. We prefer not to run code unconditionally, so the if [ -f ${config} ] block should probably be in a prestart method. Finally the traditional way of daemoninzing is to make command /usr/sbin/daemon, and command_args include the thing to start. There are numerous examples of this, it should not be too hard to find one. hth, Doug On 12/15/2010 14:44, Philip M. Gollucci wrote: > pgollucci 2010-12-15 22:44:42 UTC > > FreeBSD ports repository > > Modified files: > net/beacon Makefile > net/beacon/files beacon.in > Added files: > net/beacon/files patch-Makefile.in > patch-common-beacon.patch > patch-libbeacon-Makefile.in > Log: > - Unbreak on !i386 > - rc.d script handle daemonize and run as nobody by default > - Bump PORTREVISION > > PR: ports/149127 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=149127 > Submitted by: Craig Leres > Approved by: janos.mohacsi@bsd.hu (maintainer) > > Revision Changes Path > 1.22 +5 -11 ports/net/beacon/Makefile > 1.3 +29 -11 ports/net/beacon/files/beacon.in > 1.1 +11 -0 ports/net/beacon/files/patch-Makefile.in (new) > 1.1 +18 -0 ports/net/beacon/files/patch-common-beacon.patch (new) > 1.1 +11 -0 ports/net/beacon/files/patch-libbeacon-Makefile.in (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/beacon/Makefile.diff?&r1=1.21&r2=1.22&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/beacon/files/beacon.in.diff?&r1=1.2&r2=1.3&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/beacon/files/patch-Makefile.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/beacon/files/patch-common-beacon.patch > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/beacon/files/patch-libbeacon-Makefile.in > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/