From owner-svn-src-head@freebsd.org Wed Feb 21 18:46:46 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBA31F1F0D7 for ; Wed, 21 Feb 2018 18:46:45 +0000 (UTC) (envelope-from 01000161b9b05f85-2dd39c19-942a-40de-8ad5-991d2c9c7000-000000@amazonses.com) Received: from a8-52.smtp-out.amazonses.com (a8-52.smtp-out.amazonses.com [54.240.8.52]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9B8366B6BC for ; Wed, 21 Feb 2018 18:46:45 +0000 (UTC) (envelope-from 01000161b9b05f85-2dd39c19-942a-40de-8ad5-991d2c9c7000-000000@amazonses.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=dqtolf56kk3wpt62c3jnwboqvr7iedax; d=tarsnap.com; t=1519238799; h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=s1aRprPWw4ZjcEP/CE1XRJdrlWNjS5LY7lBeK6+AJmM=; b=I3e/NEbZp+u+TpgqekxQx0is8rrzEoqx9kVtju+Axuj04xhT2jlb/31B52JybFRZ 5x1WMhUyFp+66eVYx+MdOSIwSOmxnG7owIQ7vbEcIiGT0cefSOR6/eFG3MdTqsaXmXS UlrNdTPjyJNXMhFKux6W16nmjFGTFDzUnAK6Ztu0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1519238799; h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=s1aRprPWw4ZjcEP/CE1XRJdrlWNjS5LY7lBeK6+AJmM=; b=bE+eLGCwr/KMcUiNzgHb6oZi35GGrulp8mJAf8x+nkPzP4WUavC4WOpTt7zWw2D6 WktzWvN3yu7cHHwislKB7Mnb9UofsRdSUgcbyYQCcZx4HEREYdaVh5mrMgQ94xM/Qpa eYd3oezUldQIoq2UNPTZ9G8Imt4abpuinYvjvG+E= Subject: Re: svn commit: r329737 - head/stand/i386/boot2 To: Benno Rice , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201802211810.w1LIApvC012656@repo.freebsd.org> From: Colin Percival Message-ID: <01000161b9b05f85-2dd39c19-942a-40de-8ad5-991d2c9c7000-000000@email.amazonses.com> Date: Wed, 21 Feb 2018 18:46:39 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <201802211810.w1LIApvC012656@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SES-Outgoing: 2018.02.21-54.240.8.52 Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 18:46:46 -0000 On 02/21/18 10:10, Benno Rice wrote: > Curiously, changing whitespace seems to cause the md5 of the .o files to differ > these days hence the following testing strategy: > > Tested by: objdump -d | md5 (both in-tree clang and lang/gcc6) Is this simply because line numbers are changing? That isn't new; I remember a case where a security advisory touched a .h file and suddenly a huge number of binaries changed because they included header file line numbers. > static inline int > strcmp(const char *s1, const char *s2) > { > - for (; *s1 == *s2 && *s1; s1++, s2++); > - return (unsigned char)*s1 - (unsigned char)*s2; > + > + for (; *s1 == *s2 && *s1; s1++, s2++); > + return (unsigned char)*s1 - (unsigned char)*s2; > } -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid