From owner-svn-src-all@freebsd.org Sun Jul 8 15:26:26 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 487BC102FF56; Sun, 8 Jul 2018 15:26:26 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D0DC979706; Sun, 8 Jul 2018 15:26:25 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-wr1-x444.google.com with SMTP id p1-v6so8429917wrs.9; Sun, 08 Jul 2018 08:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9X7E7ebd/vk+nPtu954N7nCU6Y+7mpWI/j5JQZd7CF0=; b=G0r2xgDdSYFDCYt9Cee9OkwpZ6/neirS04XcZKLD3llitfGLRzie7XEqSEKL3P0NW8 I1J+ZWhvvmWqRNHdADAFhOxaOSrVNQqSaK9vy01nap+kxycN/tnC5TeaLXmLC1eCVuii THCUXkbLXGA1/axAkr2YdgF+jhUXGUhtpcBY2K0ptHs/Tuyt+rYZYWRxJTVYjTGCbieG PI6cL1w+KnfvqaV6ZnhcLhI+Z7KMtSF35MVkT7dibjdaSqxelEJMS3SFl9E8OfKz89BO asXOGn10ccjDiXKnnSrLJUkTeFNmZRYWd0Bmzliz9e+KgYoVbnI6sY2Sf722ttu5he/5 d/Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=9X7E7ebd/vk+nPtu954N7nCU6Y+7mpWI/j5JQZd7CF0=; b=M3p1PTnIXlTSHbiHB8e+S+dIl+wy8NOHGsY6R7ia17YAAjxoVqY23xMvquvS2bbRHI TiIEPp4fD2ZIyDPU1UEBk5eUL68HyK+nUqEuzup86I4Hdw9YJGYryDMNwGJucRd6e/x4 VSIZMABGRb17tgB+cyEO4DxzdRZZeSSDgxpOC/Dni75kl1Q2Jbw9KTzZFwt1GH2SKCnk DNMdtZbuRSdHmu7MGInxxgyl40qRN3KvEKrJWMz0VMOnEjqkLiQaGHRihjcHYlc36Jd1 N/ZmlibrHyAuP8ePJWtdEL25l92B5JcSmat/+W8+dmNYZ2w83dMz5uLTVwFIvS4GeAZ7 2aBA== X-Gm-Message-State: APt69E2g/8Y00/DZhUTVRHy7YES9i7cCSMVqc0zreZx2kADhBNNxNhJe qfmwrUIqtbblZdK2RpQW0sbLQQ== X-Google-Smtp-Source: AAOMgpcMuc7CYF0bHGQfWbVoKdC/tt8IW3OI6rPOMBrjQOHAKxXpyrtQzXC9LCAeecaTLg7FLfrZNw== X-Received: by 2002:adf:9996:: with SMTP id y22-v6mr13322926wrb.69.1531063584574; Sun, 08 Jul 2018 08:26:24 -0700 (PDT) Received: from pesky (174.red-81-43-74.staticip.rima-tde.net. [81.43.74.174]) by smtp.gmail.com with ESMTPSA id h4-v6sm13689821wre.89.2018.07.08.08.26.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Jul 2018 08:26:23 -0700 (PDT) Sender: Mark Johnston Date: Sun, 8 Jul 2018 11:26:21 -0400 From: Mark Johnston To: Sean Bruno Cc: Andrew Turner , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334880 - head/sys/dev/vnic Message-ID: <20180708152621.GB18193@pesky> References: <201806091447.w59ElnpU026396@repo.freebsd.org> <20180707174351.GA95934@pesky> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2018 15:26:26 -0000 On Sun, Jul 08, 2018 at 09:10:27AM -0600, Sean Bruno wrote: > > > On 07/07/18 11:43, Mark Johnston wrote: > > On Sat, Jun 09, 2018 at 02:47:49PM +0000, Andrew Turner wrote: > >> Author: andrew > >> Date: Sat Jun 9 14:47:49 2018 > >> New Revision: 334880 > >> URL: https://svnweb.freebsd.org/changeset/base/334880 > >> > >> Log: > >> In the ThunderX BGX network driver we were skipping the NULL terminator > >> when parsing the phy type, however this is included in the length returned > >> by OF_getprop. To fix this stop ignoring the terminator. > >> > >> PR: 228828 > >> Reported by: sbruno > >> Sponsored by: DARPA, AFRL > > > > This seems to break vnic on packet.net ThunderXs. In particular, VF > > creation fails. It seems the problem in my case is that there are > > multiple PHY devices in the device tree, e.g., xfi@0, xfi@1. With this > > change, bgx_fdt_phy_name_match() fails to match against any device > > containing a unit address in the node name. > > > > > Huh ... this was *required* to get the ThunderXs we have in the FreeBSD > cluster to work at all. o.0 > > I guess "someone" needs to contact "someone" to figure out which is > correct or we need to replace our FreeBSD cluster machines with ones > that work like the packet.net machines? I think the current code works fine if there's only one PHY device, so my problem is probably just the result of having a different hardware setup. We can probably fix the code to handle both cases. Could you mail me the output of "ofwdump -ap" from the cluster machine?