From owner-freebsd-current@freebsd.org Mon Dec 3 21:00:36 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9EE0B130BA47 for ; Mon, 3 Dec 2018 21:00:36 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 599226ED0D; Mon, 3 Dec 2018 21:00:34 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id AC40A2235B; Mon, 3 Dec 2018 16:00:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 03 Dec 2018 16:00:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type; s=fm3; bh=2icIZES1wRpvIcQMTuZpMWHAQip pkkEfeakx9tYywYY=; b=EeQ7dAZQT3wJDsdpN8tIRtcZ60vlxsZj+0KWabeJaPD XNgAsQwwxkoL1IZF7G8q5wLaJsiDSDJ+WWwDNnaHGRA75aLfqzQsy2YqRWjHjnQl uNsGijxzkVGLlOa4DUSuMzUi3xQuzKYnOE41kfQky/JADCrMI/8gHLiCdy6l8Akc 1YROzch6sRNa1c6aLg1z3xHrQerQyYEm383xCYivuE3Vlb1BANDcU/cxLalaLi2M taoXzu3O6OZwo+HLBQyGtTIqAKTFcj81tWHBQjdj1NP2b6m3NBxOn9Gk5rgoB0KS Z3GNwrMHWYzGvFn7y2fd/9vKSPcrlHASOPlx0hzoDgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=2icIZE S1wRpvIcQMTuZpMWHAQippkkEfeakx9tYywYY=; b=VF6tyWWVus2zQVGbHJaScn 0JNOGyE4hyjfoPxP+XWVKyeDqtR0t5xIatt/bzR3bwBz4afjg44HE9tRlw9WK4Ve x1NEhWKh9A5EgpaWmdqi1bLoFPDawIqFHxmsfKdaM/YQs6kxpNFcy4la9SjpqkXg 76pbah6Gyz0P1yjEHj3JZG04f1xPQh1eLxj+YkioxmtGevW2/g3+Zz1S0x20+BD1 mtHRHj59edaE8PDnmw5x+i3NB3uglxJneiMgB9+SBa2wXZiz5ItQEJYvTuyzfTXM SGelAlp0fhL/Js2KFeI2tFjQSGh+VS33pTGC4illlmWxpVepHpl65Keggw9hNffQ == X-ME-Sender: X-ME-Proxy: Received: from [192.168.1.2] (unknown [62.183.125.176]) by mail.messagingengine.com (Postfix) with ESMTPA id 986A7102FE; Mon, 3 Dec 2018 16:00:31 -0500 (EST) Subject: Re: WITH_CTF breaks CD loader: "File too big" To: Warner Losh Cc: Baptiste Daroussin , FreeBSD Current References: <6e53765f-52bd-f503-c1a5-ae23e402afcb@yuripv.net> <20181203072226.mpvh7an5pupjbwkb@ivaldir.net> <51d0fa8c-b453-69e0-500e-32818d29826a@yuripv.net> From: Yuri Pankov Openpgp: preference=signencrypt Autocrypt: addr=yuripv@yuripv.net; keydata= xsBNBFu8u6IBCADB11gP0QwnorrHjqAtKLHKHNHskhy0s7jqJKfx0YqXgVBKGLJ9/mjLAz0F CBNvemHSDDTs0mEZ9cBKKi6cmsav6+UQgr//yai6hvXLBJqKchSFO4MhmdvBtsGFq1yKz5Zi uhjmimKyIpgBgvMdbgGbGq6cnSB2uEPmZuJr419SVRODOkXukU+F5WHgaHzDdHAIu1asCt2B +6msxqIqlFWcXyZyTGicTGGvC/PFIsVRUtD1dIJANTC876g7DTb7LZXWiWwJpSJ4GKMXMHVX Ct9BoQ4i3nhKbOxb6Io1wsy+NFyWsTJ9KYrxKKPJP3oG8BWb/cqlFqnE4eNSsiq2q7krABEB AAHNH1l1cmkgUGFua292IDx5dXJpcHZAeXVyaXB2Lm5ldD7CwJcEEwEIAEECGwMFCQWjmoAF CwkIBwMFFQoJCAsFFgMCAQACHgECF4AWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW708wAIZ AQAKCRCTi+B/sSrhbPxBB/961alcU091O+yKT5/oReHVc/PX0Tz4sW3V44AcgLfYlrZavCro EFz90qmCrl0xqEwuAKcC4bjmL8SjPWAhSN6IH9nxdw+HeZnAPiHm/q679Bu47+nHBl3qD/9p +t1PkKeKZfaWToFMt1nq06ytSu6VLMCwLdlDNe6DReX0ex/afEqKsuaIZSKL4UYjRwklp8PU Uf98QkrfapyHB67hQMzfI4tPeJaYyv0cTgfq3kUWJx1V6Xi0b6Zxj4ZrB2TXvaMO5g7yhU9E E3WWAvoe4FgB3a7dHe8atnHhq5+Cuvm6+LD4Jh7jvMAE5UMN+xxQpnGpNghHjaCy4vXrLRBZ nhRYzsBNBFu8u6IBCADKih3Q933rDNj4ZA8FhBQ2RlmBgvwOLcDPIL3h0V7h38y3+HisgFSc XACDsdrTlYZ1bRXkD9FHENynBcv0l/3uGJDk8jaGIDE0TP8OQBRp+IaU9/BHnAqrKxTJGIol Dahy2m+yx2yhdc6B4ujWMDqCF1rWOD+ymOWw+VLllOkrHcZa5PJtX9UOGbApZl8ZTM8El4CA NN8F1bg9MWzUi+8LYoGWGc+BwsFS1OUB1c4SPgMu5fD4Wfsr9yRl06fdpEA2YT7B/j5/5RSC 0sE2Zs/tmJ/JRflHJ12ycj59ma2xQMfEJF40hZDpMFQmZvbVqgEg3ocQcltjbxlIKZ/mjC4z ABEBAAHCwHwEGAEKACYWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW7y7ogIbDAUJBaOagAAK CRCTi+B/sSrhbIDcCACqAZMcoxUBLZa40a5b24j5i1jplvCYYb3h+Q5lt5+BFJ87kCb4dJuU D3kh2i29BrxWQWa9WNue9ozxeYkbkfXubQYXexVolRsnh64OdGsE8KvorBFBB3zdK/GRt2Jy +jsnTfUWuQllbzMP0MfhCDMk1Mo8WvDH2/cOEP/yLKf20a+cd6nLs7bidjmGXo9pyuBKAtV6 Kv+VRu54AL+A/UBYu/eB3Dtvzcnut+1Zq6KaP++kUwPwINLIk04OBDwN0zRNTiqMAFYYyz2v ZHBB6E1th/l//ZC5b9Dk0ZpFI1bYdL9ymnrZe1MqbGPnDCToQxu00T/pZCm6Z92YrZQYuNwl Message-ID: Date: Tue, 4 Dec 2018 00:00:23 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4747jgS1C3Od1olATYjOrz6uRTnW2lODU" X-Rspamd-Queue-Id: 599226ED0D X-Spamd-Result: default: False [-9.36 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[yuripv.net,messagingengine.com]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.28]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; HAS_ATTACHMENT(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; DMARC_NA(0.00)[yuripv.net]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[cached: in2-smtp.messagingengine.com]; DKIM_TRACE(0.00)[yuripv.net:+,messagingengine.com:+]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; SIGNED_PGP(-2.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[28.4.111.66.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-3.67)[ip: (-9.64), ipnet: 66.111.4.0/24(-4.77), asn: 11403(-3.85), country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2018 21:00:37 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4747jgS1C3Od1olATYjOrz6uRTnW2lODU Content-Type: multipart/mixed; boundary="aLMB4jmQHyhth5JJJldBEwBIQCaGv74c7"; protected-headers="v1" From: Yuri Pankov To: Warner Losh Cc: Baptiste Daroussin , FreeBSD Current Message-ID: Subject: Re: WITH_CTF breaks CD loader: "File too big" References: <6e53765f-52bd-f503-c1a5-ae23e402afcb@yuripv.net> <20181203072226.mpvh7an5pupjbwkb@ivaldir.net> <51d0fa8c-b453-69e0-500e-32818d29826a@yuripv.net> In-Reply-To: --aLMB4jmQHyhth5JJJldBEwBIQCaGv74c7 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Warner Losh wrote: > On Mon, Dec 3, 2018 at 11:14 AM Yuri Pankov wrote: >=20 >> Warner Losh wrote: >>> On Mon, Dec 3, 2018 at 9:56 AM Yuri Pankov wrote:= >>> >>>> Yuri Pankov wrote: >>>>> Warner Losh wrote: >>>>>> On Mon, Dec 3, 2018 at 8:10 AM Warner Losh wrote:= >>>>>> >>>>>>> >>>>>>> On Mon, Dec 3, 2018 at 12:24 AM Baptiste Daroussin >> >>>>>>> wrote: >>>>>>> >>>>>>>> On Sun, Dec 02, 2018 at 06:08:34PM +0300, Yuri Pankov wrote: >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Building disc1.iso using `make release` and having WITH_CTF set= in >>>>>>>>> src.conf leads to "File too big" displayed when booting the ima= ge. >>>>>>>>> >>>>>>>>> Would it make sense to build loader and related parts without C= TF >>>>>>>>> unconditionally as it doesn't look useful there? >>>>>>>>> >>>>>>>> >>>>>>>> Fully agree with you >>>>>>>> >>>>>>> >>>>>>> What a great Idea. We already turn it off in defs.mk: >>>>> >>>>> Sorry about that, I incorrectly assumed it wasn't done yet as there= was >>>>> a difference for me. >>>>> >>>>>>> MK_CTF=3D no >>>>>>> >>>>>>> which should be global to every single Makefile under stand. I'm = not >>>> sure >>>>>>> why that's turning it back on. >>>>>>> >>>>>> >>>>>> % cat /etc/src.conf >>>>>> WITH_CTF=3Dyes >>>>>> FRED=3Dpresent >>>>>> % cd stand/cdboot >>>>>> % make -V MK_CTF >>>>>> no >>>>>> % make -V FRED >>>>>> present >>>>>> % >>>>>> >>>>>> So this sure sounds like a false positive to me. Do you have logs >>>> showing >>>>>> cdboot building with MK_CTF=3Dyes? >>>>> >>>>> Diff'ing the log for src/stand w/o and with -DWITH_CTF shows a lot = of >>>>> ctfconvert calls in the latter case. Attached is the diff of binar= y >>>>> sizes in obj/ for stand/i386; could one of those be the problem I'm= >>>> seeing? >>>> >>>> If ctfconvert calls are indeed the source of problem, then something= >>>> seems to be wrong here (I didn't mention the "cdboot" binary exactly= , >>>> rather the binary it's trying to load): >>>> >>>> yuripv:~/ws/ctf/stand/i386/loader$ make -V MK_CTF -V CTFCONVERT_CMD >>>> no >>>> >>>> yuripv:~/ws/ctf/stand/i386/loader$ make -DWITH_CTF -V MK_CTF -V >>>> CTFCONVERT_CMD >>>> no >>>> ctfconvert -L VERSION ${.TARGET} >>>> >>> >>> Ding! We have a winner: order of operations not quite right. We incl= uded >>> src.opts.mk which includes bsd.own.mk which defines CTFCONVERT_CMD an= d >> then >>> we change the MK_CTF value which has no effect. Unlike the lazy >> evaluation >>> in makefile rules, where the last one wins, when we're parsing stuff = for >>> .if, it's the current value that's used. The solution is to include >>> src.opts.mk later after we set the MK_foo overrides. >>> >>> r341433 should fix that. >> >> Thank you. >> >=20 > Please give it a spin and let me know if we're golden. I'll MFC it then= > since this should be in 12.1. Done. Everything looks good now - having clean /usr/obj/; world/kernel built with WITH_CTF=3D in /etc/src.conf; successfully booted the disc1.is= o built using `make cdrom`. --aLMB4jmQHyhth5JJJldBEwBIQCaGv74c7-- --4747jgS1C3Od1olATYjOrz6uRTnW2lODU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlwFmWgACgkQk4vgf7Eq 4WwfmQf/U4MBznFtOHZmFF4sfChMcQhdamntuYm2Knu6OUYcG9QknuVe0QEC9131 8GVqaBRj7d4tW+BEBTeKLk7hQhQdwYkA+qfGYrYmcu0DxvemR9sa/CyS6fj1srJj 5hy5sjuk0iTzDHSUyBUShYI3XWOoAGKkQdKOfM4/nb8GcSmAoR3jkUxWNv1jus41 7zon4tb31gnOyBpOe3LupdYuP9Mly/sa3h/wMBHhmrL+vInH9e2tzstZvxJv7SS0 8XTR4a9VI5DfE54QEgTk+12W4MIO4VjyzMhLhlXwgzFOVSLZfjppvLimIYA7mPPB cuQ2aDSir8j8QIK64ocTo46ekrQEYw== =14b+ -----END PGP SIGNATURE----- --4747jgS1C3Od1olATYjOrz6uRTnW2lODU--