From owner-svn-src-head@FreeBSD.ORG Sat Feb 14 19:46:29 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D51A1065672; Sat, 14 Feb 2009 19:46:29 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 0C0218FC0C; Sat, 14 Feb 2009 19:46:29 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n1EJkSC4028691; Sat, 14 Feb 2009 19:46:28 GMT (envelope-from ed@svn.freebsd.org) Received: (from ed@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n1EJkS34028690; Sat, 14 Feb 2009 19:46:28 GMT (envelope-from ed@svn.freebsd.org) Message-Id: <200902141946.n1EJkS34028690@svn.freebsd.org> From: Ed Schouten Date: Sat, 14 Feb 2009 19:46:28 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r188609 - head/sys/dev/usb2/core X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2009 19:46:29 -0000 Author: ed Date: Sat Feb 14 19:46:28 2009 New Revision: 188609 URL: http://svn.freebsd.org/changeset/base/188609 Log: Remove unneeded execute-permissions from the USB2 device node. Giving a charactere device execute permissions doesn't have any use. Right now there isn't a single device node in /dev that has it, except the USB2 device node, so remove it. Approved by: hps, thompsa Modified: head/sys/dev/usb2/core/usb2_dev.c Modified: head/sys/dev/usb2/core/usb2_dev.c ============================================================================== --- head/sys/dev/usb2/core/usb2_dev.c Sat Feb 14 18:23:52 2009 (r188608) +++ head/sys/dev/usb2/core/usb2_dev.c Sat Feb 14 19:46:28 2009 (r188609) @@ -1466,13 +1466,13 @@ usb2_dev_init_post(void *arg) * should never be opened. Therefore a space character is * appended after the USB device name. * - * NOTE: The permissions of this device is 0777, because we + * NOTE: The permissions of this device is 0666, because we * check the permissions again in the open routine against the - * real USB permissions which are not 0777. Else USB access + * real USB permissions which are not 0666. Else USB access * will be limited to one user and one group. */ usb2_dev = make_dev(&usb2_devsw, 0, UID_ROOT, GID_OPERATOR, - 0777, USB_DEVICE_NAME " "); + 0666, USB_DEVICE_NAME " "); if (usb2_dev == NULL) { DPRINTFN(0, "Could not create usb bus device!\n"); }