From owner-svn-src-head@FreeBSD.ORG Sat Nov 3 23:32:33 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1F6EBBE7; Sat, 3 Nov 2012 23:32:33 +0000 (UTC) (envelope-from attilio@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 07E9F8FC0A; Sat, 3 Nov 2012 23:32:33 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id qA3NWW1K067318; Sat, 3 Nov 2012 23:32:32 GMT (envelope-from attilio@svn.freebsd.org) Received: (from attilio@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id qA3NWWLN067315; Sat, 3 Nov 2012 23:32:32 GMT (envelope-from attilio@svn.freebsd.org) Message-Id: <201211032332.qA3NWWLN067315@svn.freebsd.org> From: Attilio Rao Date: Sat, 3 Nov 2012 23:32:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r242536 - head/sys/fs/fuse X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Nov 2012 23:32:33 -0000 Author: attilio Date: Sat Nov 3 23:32:32 2012 New Revision: 242536 URL: http://svn.freebsd.org/changeset/base/242536 Log: Fix a bug where operations was carried on even if not implemented, leading to handling of an invalid fdip object. Reported and tested by: flo MFC after: 2 months X-MFC: 241519 Modified: head/sys/fs/fuse/fuse_vnops.c Modified: head/sys/fs/fuse/fuse_vnops.c ============================================================================== --- head/sys/fs/fuse/fuse_vnops.c Sat Nov 3 23:22:49 2012 (r242535) +++ head/sys/fs/fuse/fuse_vnops.c Sat Nov 3 23:32:32 2012 (r242536) @@ -358,12 +358,10 @@ fuse_vnop_create(struct vop_create_args err = fdisp_wait_answ(fdip); - if (err == ENOSYS) { - debug_printf("create: got ENOSYS from daemon\n"); - fsess_set_notimpl(mp, FUSE_CREATE); - fdisp_destroy(fdip); - } else if (err) { - debug_printf("create: darn, got err=%d from daemon\n", err); + if (err) { + if (err == ENOSYS) + fsess_set_notimpl(mp, FUSE_CREATE); + debug_printf("create: got err=%d from daemon\n", err); goto out; } bringup: