From owner-svn-src-head@freebsd.org Fri Aug 12 22:23:14 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FD1CBB8E9F; Fri, 12 Aug 2016 22:23:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22b.google.com (mail-pf0-x22b.google.com [IPv6:2607:f8b0:400e:c00::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2AFF6117C; Fri, 12 Aug 2016 22:23:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22b.google.com with SMTP id p64so12703964pfb.1; Fri, 12 Aug 2016 15:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=+bNLcWY8nG97imcfmvmI8LEQ0JVeSRAcOt6ekoi7/14=; b=Uwq73QMx4qUEaWT8Bjnm+7z64aJqNRQOVB2HS4WLFsoPigjpABuhYZQ9IlvjyfS5J/ 507xfpubFTtZoMHLojViZJ5uauvUU/3j+GO+p3Ee0+AEgY/R/tcl/3JaAV7dT5aVNn9i MKZhAMa/jgeHJ9sxgTZ0g3EUxSiq/w5NOmkPz1fufQec97sADBFC97Qq9nicdsE73Y+R TB9vDWmfw/WjmnKcXMFmwWttlsZW+jgk6i0ji2Ri+3igpDIJ6g1H8PcwH1g/SYwdycey LVX6nzvmnfoQZj4dJtRmmn0NRjthy6kMqVA4Z9C373r9yyqa95Nfex2a+47wvtiFyh0X jldg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=+bNLcWY8nG97imcfmvmI8LEQ0JVeSRAcOt6ekoi7/14=; b=eUISq896yjMmp14OvPNsuYBZLla9VYwuFqaPluaRD9iFgeK1i5ITxDstojFXGUvGa6 uSJIWErWVuiBoesKMHBXkb51WPtnA277qES1EmNO9/WAvqp9iNaueWIl6h2i+KQU3O66 R4dr6ZVN2PtWDrESkvqPMPCz/wSx+I0oKI7CYcNL2nb22oRDYzPng7xQdahfXCW7kr9x b2MSbxM7EUWDS1UZ4t49c3a2mSpL/KGdAO6/NB+xvekpl63ktaomf13qJ939YSF7TsVj PNEZIeqC3yuNmEUny3Vd8c6tLelXHLcpo6lP6K8UzI7/sLukii0CQfbdxPGWfsMf/2DQ NMZQ== X-Gm-Message-State: AEkoouuImKW0UvDkJVMPF1ko+uSk/SdxrYWlfKX6Bko+Ra0hvq3Fq44sNBJljYnCzGrMsw== X-Received: by 10.98.7.200 with SMTP id 69mr31148041pfh.33.1471040593686; Fri, 12 Aug 2016 15:23:13 -0700 (PDT) Received: from pinklady.west.isilon.com (scl-nat-134.emc.com. [137.69.117.134]) by smtp.gmail.com with ESMTPSA id j2sm15349807paa.46.2016.08.12.15.23.12 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 12 Aug 2016 15:23:12 -0700 (PDT) Subject: Re: svn commit: r303848 - head/sys/netgraph Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_A15DCF97-7671-4AC3-A4E4-029F9C77DFDA"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <20160812183845.GJ1076@FreeBSD.org> Date: Fri, 12 Aug 2016 15:23:11 -0700 Cc: Sean Bruno , Michael Zhilin , Garrett Cooper , sergey.dyatko@gmail.com, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <96EEC230-97EA-4686-9AFC-D5D6F98E70E8@gmail.com> References: <201608081931.u78JV1Ve026577@repo.freebsd.org> <20160812183845.GJ1076@FreeBSD.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 22:23:14 -0000 --Apple-Mail=_A15DCF97-7671-4AC3-A4E4-029F9C77DFDA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 12, 2016, at 11:38, Gleb Smirnoff wrote: >=20 > Hi! >=20 > Sorry, I'm afraid this isn't a correct fix. Simply adding checks > against NULL to avoid panics at race conditions isn't a solution. >=20 > I can provide help with this problem. It must be related to my > callout changes, in case if this is a very recent problem. >=20 > Is it a recent problem or an old one? I should have requested that the change be revised or further qualified = first=E2=80=A6 as I said in the CR: =E2=80=9C=E2=80=9D=E2=80=9D In D7209#150056, @bz wrote: Is this sudden problem possibly related to glebius' callout changes? I = am not properly tracking things but if invariants changed and weren't = reflected in the callers, that might explain. I don't know to be honest. I'll add glebius (I should have done that in the first place). =E2=80=9C=E2=80=9D=E2=80=9D Thanks, -Ngie --Apple-Mail=_A15DCF97-7671-4AC3-A4E4-029F9C77DFDA Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXrkxPAAoJEPWDqSZpMIYVQSIP+wV+4X6wQhck3zD7EmZuZk3v sfE0jlfQ+wTWJ/zHhxUb/9lEsb4ss/j+0zcXVj7xsC6Mb+/I/X35du1SQbxWN3ga rFEelSqQK5x2ejao+A0iscXeKkZczu4KjfeTeQjqyfL5uaoFjbUYyBK+BIxNe4fw pvulKObZvrA8q5CSsPh/bynWQ+NZJ6d5ehhZFABC/D9ePYNj3ALmT5aGjbt6Jm5A F/0a38HGLlw0wBl6XSfcDuctFVHXKFQh6nK6TbJbmbhBqV4utN8Ke/5x++ZUq7HM 31CAU3LHTSI0bl64Jp9MSX/m8BwcNV49FqZ6kPlXkRtUnmaiMmwM0srKS+1h94IY 7UhqdsXAjB/JZU+qHp+VyiUEgryfiRBpR3bQu87iwCjviqr+Df+xsj2eDP5Lv3A/ mx5zBRfB/zIqVp/Nxvp069P4IT8pCBkbFrfnQNKve0LRI8SJbDPqfCnGvg7vls6C 6N7wCWeWh1kaW5BiJQnEyhV7RsZ8RiWPFY9R3AItzw2JLrqfFh01W+gQGdu8Lb/7 fmlZL+rZ57yVw5LdM2z4bB6P2SygfnzWwOp+1US8EBQtx588HJEVDhRPkbGrXyoY lhocyqGM3uf9QRsaxJ8cfVkr7K4WWh3VTfZ1Lulz8q5fXHq2Io6/MUcVbHn3KJqV OYGlgFKpSobqGJhq0NUs =WNWG -----END PGP SIGNATURE----- --Apple-Mail=_A15DCF97-7671-4AC3-A4E4-029F9C77DFDA--