Date: Fri, 12 Aug 2016 15:23:11 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Sean Bruno <sbruno@FreeBSD.org>, Michael Zhilin <mizhka@gmail.com>, Garrett Cooper <ngie@FreeBSD.org>, sergey.dyatko@gmail.com, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303848 - head/sys/netgraph Message-ID: <96EEC230-97EA-4686-9AFC-D5D6F98E70E8@gmail.com> In-Reply-To: <20160812183845.GJ1076@FreeBSD.org> References: <201608081931.u78JV1Ve026577@repo.freebsd.org> <20160812183845.GJ1076@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_A15DCF97-7671-4AC3-A4E4-029F9C77DFDA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 12, 2016, at 11:38, Gleb Smirnoff <glebius@FreeBSD.org> wrote: >=20 > Hi! >=20 > Sorry, I'm afraid this isn't a correct fix. Simply adding checks > against NULL to avoid panics at race conditions isn't a solution. >=20 > I can provide help with this problem. It must be related to my > callout changes, in case if this is a very recent problem. >=20 > Is it a recent problem or an old one? I should have requested that the change be revised or further qualified = first=E2=80=A6 as I said in the CR: =E2=80=9C=E2=80=9D=E2=80=9D In D7209#150056, @bz wrote: Is this sudden problem possibly related to glebius' callout changes? I = am not properly tracking things but if invariants changed and weren't = reflected in the callers, that might explain. I don't know to be honest. I'll add glebius (I should have done that in the first place). =E2=80=9C=E2=80=9D=E2=80=9D Thanks, -Ngie --Apple-Mail=_A15DCF97-7671-4AC3-A4E4-029F9C77DFDA Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXrkxPAAoJEPWDqSZpMIYVQSIP+wV+4X6wQhck3zD7EmZuZk3v sfE0jlfQ+wTWJ/zHhxUb/9lEsb4ss/j+0zcXVj7xsC6Mb+/I/X35du1SQbxWN3ga rFEelSqQK5x2ejao+A0iscXeKkZczu4KjfeTeQjqyfL5uaoFjbUYyBK+BIxNe4fw pvulKObZvrA8q5CSsPh/bynWQ+NZJ6d5ehhZFABC/D9ePYNj3ALmT5aGjbt6Jm5A F/0a38HGLlw0wBl6XSfcDuctFVHXKFQh6nK6TbJbmbhBqV4utN8Ke/5x++ZUq7HM 31CAU3LHTSI0bl64Jp9MSX/m8BwcNV49FqZ6kPlXkRtUnmaiMmwM0srKS+1h94IY 7UhqdsXAjB/JZU+qHp+VyiUEgryfiRBpR3bQu87iwCjviqr+Df+xsj2eDP5Lv3A/ mx5zBRfB/zIqVp/Nxvp069P4IT8pCBkbFrfnQNKve0LRI8SJbDPqfCnGvg7vls6C 6N7wCWeWh1kaW5BiJQnEyhV7RsZ8RiWPFY9R3AItzw2JLrqfFh01W+gQGdu8Lb/7 fmlZL+rZ57yVw5LdM2z4bB6P2SygfnzWwOp+1US8EBQtx588HJEVDhRPkbGrXyoY lhocyqGM3uf9QRsaxJ8cfVkr7K4WWh3VTfZ1Lulz8q5fXHq2Io6/MUcVbHn3KJqV OYGlgFKpSobqGJhq0NUs =WNWG -----END PGP SIGNATURE----- --Apple-Mail=_A15DCF97-7671-4AC3-A4E4-029F9C77DFDA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96EEC230-97EA-4686-9AFC-D5D6F98E70E8>