Date: Wed, 15 Apr 2015 11:15:21 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r383191 - head/Mk Message-ID: <552E8E99.1050309@FreeBSD.org> In-Reply-To: <20150409162416.GA54797@FreeBSD.org> References: <20150408194202.GA45809@hades.panopticon> <5525A9C1.5010003@FreeBSD.org> <20150408232144.GX21982@hades.panopticon> <5525D48E.5090305@FreeBSD.org> <20150409110221.GB45809@hades.panopticon> <55269785.7030307@FreeBSD.org> <20150409153856.GA31951@FreeBSD.org> <55269FE4.2030208@FreeBSD.org> <20150409160330.GB31951@FreeBSD.org> <5526A52E.4090801@FreeBSD.org> <20150409162416.GA54797@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FqBJ0AALb3C1jBF7mXkxI5SpS8RTOfqWl Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4/9/2015 11:24 AM, Alexey Dokuchaev wrote: > On Thu, Apr 09, 2015 at 11:13:34AM -0500, Bryan Drewery wrote: >> On 4/9/2015 11:03 AM, Alexey Dokuchaev wrote: >>> On Thu, Apr 09, 2015 at 10:51:00AM -0500, Bryan Drewery wrote: >>>> Read the commit log again for r369644. Setting one var and not the o= ther >>>> leads to incorrect behavior in many ports. You must have them matchi= ng. >>>> It is not just about jails/chroots. >>> >>> I've (re)read it and understand what you're trying to accomplish; my = point >>> here is not to *build* things against custom OSVERSION, but just chec= k if >>> some variables are set correctly, e.g. "make -V FOO OSVERSION=3Dxxx" = is what >>> I miss. Is there a way to allow it again somehow? >> >> I understand what you're trying to do and I agree it would be useful i= f >> it worked. Validating port logic (such as whether EXTRA_PATCHES has >> something) based on OSVERSION is very useful. I'll think about how to >> fix it. >=20 > Right, EXTRA_PATCHES is a very good example. Good to know that there i= s > mutual understanding now and a chance for a fix. :) Thanks, >=20 > ./danfe >=20 Fixed in r384060. You can now specify it on the cmdline. make -V BLAH OSVERSION=3Dblah. If it is in env or make.conf it will still error. --=20 Regards, Bryan Drewery --FqBJ0AALb3C1jBF7mXkxI5SpS8RTOfqWl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVLo6ZAAoJEDXXcbtuRpfP77cIAIINVzzhUT84Ae4CJ+siIOAJ DtDVlKRH67IMY5Ko7p/1Vz9rDfXf8a/VU9cvr8QjFbWx3TUCdDcWD3tjJ9puxEoa 2cEV50RQDNtiXyUpym002SmMFpN8EvqOUR0ucSee2iliii4QUp/8YrDMjBiXyBUg MKrnh0Y7vqLstGiZWsYhUyMuGQuLLFQ1A18wtee6TD7n77YExWvkIyv2P36JU9OM oaNH78gpT25Qe/assmJj/a9ByJkKkKsI8cT/2DqXcvDslWGUXAbMQ8Rur3Y/rlB2 0ZNc2alxbNAeBu+h12V7rarcevM3R6pHvkOY6LO1Nwt8Jk7i68YVwLO+04YhWDE= =QTxd -----END PGP SIGNATURE----- --FqBJ0AALb3C1jBF7mXkxI5SpS8RTOfqWl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?552E8E99.1050309>