From owner-svn-src-all@FreeBSD.ORG  Fri Dec 21 02:07:48 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 1F020E9C;
 Fri, 21 Dec 2012 02:07:48 +0000 (UTC)
 (envelope-from yanegomi@gmail.com)
Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com
 [209.85.214.182])
 by mx1.freebsd.org (Postfix) with ESMTP id A21EB8FC14;
 Fri, 21 Dec 2012 02:07:47 +0000 (UTC)
Received: by mail-ob0-f182.google.com with SMTP id 16so4009502obc.41
 for <multiple recipients>; Thu, 20 Dec 2012 18:07:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=yAq0sv19E/kcqWj51fr7jhlWgLtSmNGgDvpVihsVeC0=;
 b=H1SV00OLuPmob8MZQ2Ioq7ReZN7Xsk5emrSWVJX5bpV4gOYld9OMr4xP/sKtbfXYqU
 x4DcCok+AhlHnuMJKwcD8nCgWdkk9c04AFvRb42tIxmK3m0mOSVOb+8Ev3Ss4/aqO4aP
 ZqGECfhYQaQh4mud5e809nJa6Uc965zXYv+EQOLiNDMrYYsjwpXdgIfd4E7DUF6L5wpj
 IGn/UyxDTLEps8ALt2N/Z2C2Mo0sZsPi+2d48vq9crawyDXblqPwUYi2ZH89dMd6msSc
 0DK4w51wn/u77CVKvQ4BcbuKpAD0RF1Sjx83I3NRq2/naoacEXazqtL00OeLXTywTCWr
 5FAw==
MIME-Version: 1.0
Received: by 10.182.2.169 with SMTP id 9mr9890464obv.66.1356055666996; Thu, 20
 Dec 2012 18:07:46 -0800 (PST)
Received: by 10.76.143.33 with HTTP; Thu, 20 Dec 2012 18:07:46 -0800 (PST)
In-Reply-To: <201212210131.qBL1Vuu4062307@svn.freebsd.org>
References: <201212210131.qBL1Vuu4062307@svn.freebsd.org>
Date: Thu, 20 Dec 2012 18:07:46 -0800
Message-ID: <CAGH67wQtTF57pPAC9WbaJtORW1fhyQZJKD3HdcFJL_14wW8oGA@mail.gmail.com>
Subject: Re: svn commit: r244526 - head/usr.sbin/mptable
From: Garrett Cooper <yanegomi@gmail.com>
To: Neel Natu <neel@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2012 02:07:48 -0000

On Thu, Dec 20, 2012 at 5:31 PM, Neel Natu <neel@freebsd.org> wrote:
> Author: neel
> Date: Fri Dec 21 01:31:56 2012
> New Revision: 244526
> URL: http://svnweb.freebsd.org/changeset/base/244526
>
> Log:
>   The MPtable specification allows for an 8-bit "BUS ID" and "I/O APIC ID".
>
>   Since the 'busses[]' and 'apics[]' arrays are indexed by these 8-bit IDs
>   make sure that they have enough space to accomodate up to 256 entries.
>
>   Submitted by: Ravi Shamanna
>   Obtained from:        NetApp
>
> Modified:
>   head/usr.sbin/mptable/mptable.c
>
> Modified: head/usr.sbin/mptable/mptable.c
> ==============================================================================
> --- head/usr.sbin/mptable/mptable.c     Fri Dec 21 01:19:48 2012        (r244525)
> +++ head/usr.sbin/mptable/mptable.c     Fri Dec 21 01:31:56 2012        (r244526)
> @@ -270,8 +270,8 @@ static void pnstr( char* s, int c );
>  /* global data */
>  static int     pfd;            /* physical /dev/mem fd */
>
> -static int     busses[16];
> -static int     apics[16];
> +static int     busses[256];
> +static int     apics[256];
>
>  static int     ncpu;
>  static int     nbus;
> @@ -711,7 +711,7 @@ MPConfigTableHeader( u_int32_t pap )
>      printf( "MP Config Base Table Entries:\n\n" );
>
>      /* initialze tables */
> -    for ( x = 0; x < 16; ++x ) {
> +    for ( x = 0; x < 256; ++x ) {

`nitems(busses)` (requires sys/param.h)?

>         busses[ x ] = apics[ x ] = 0xff;
>
>      }

Thanks,
-Garrett