From owner-freebsd-stable@FreeBSD.ORG Fri Mar 12 20:02:29 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8EBBD106567E; Fri, 12 Mar 2010 20:02:29 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-fx0-f223.google.com (mail-fx0-f223.google.com [209.85.220.223]) by mx1.freebsd.org (Postfix) with ESMTP id E855A8FC13; Fri, 12 Mar 2010 20:02:28 +0000 (UTC) Received: by fxm23 with SMTP id 23so1575199fxm.3 for ; Fri, 12 Mar 2010 12:02:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=QeObv8RgKiQhMvQBTh+JzIWYl9o26JX5/9MlSwkHEfM=; b=Ni5WoB09SaJCh/5KVMj2nzQxNadcKHreQ2T4onPFAOBbeZtGHhyIuIQQ90pV7uvuUK x5jLVFpbkK33mBJlviUNZyAO1mfZN9XDC+eFOXquFgGEnBzjrQnIixSm/Q6mSCTLWVL2 9VWuAbJDk5Pom5CKDRWNbyE1bxDcUZyefkBbc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=pnJIaBFIfhD4eSZTYESqUVG2x+5EsflINioZ5JUiT8vCyHacE/I4HIM0hVX7xPpMkL vAK433SjZl9o1CzU5YKVvaTf2Pv7GzBNA5/cmDorLoBZz8psyCyoncxAEViPQZ0T+jEH o3oW6j2NAPU+GWRuMI5xlVbUEaicWcFgjhzlE= Received: by 10.87.63.20 with SMTP id q20mr2719182fgk.27.1268424147291; Fri, 12 Mar 2010 12:02:27 -0800 (PST) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id e20sm2043609fga.0.2010.03.12.12.02.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 12 Mar 2010 12:02:25 -0800 (PST) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Fri, 12 Mar 2010 12:02:24 -0800 From: Pyun YongHyeon Date: Fri, 12 Mar 2010 12:02:24 -0800 To: Pierre Beyssac Message-ID: <20100312200224.GO16314@michelle.cdnetworks.com> References: <20100312121409.GA79294@fasterix.frmug.org> <20100312174655.GG16314@michelle.cdnetworks.com> <20100312182134.GA90606@fasterix.frmug.org> <20100312192144.GL16314@michelle.cdnetworks.com> <20100312194524.GB91694@fasterix.frmug.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="NU0Ex4SbNnrxsi6C" Content-Disposition: inline In-Reply-To: <20100312194524.GB91694@fasterix.frmug.org> User-Agent: Mutt/1.4.2.3i Cc: freebsd-stable@freebsd.org Subject: Re: 8-STABLE interrupt storm on atapci(?), Dell Inspiron 580 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2010 20:02:29 -0000 --NU0Ex4SbNnrxsi6C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 12, 2010 at 08:45:24PM +0100, Pierre Beyssac wrote: > On Fri, Mar 12, 2010 at 11:21:44AM -0800, Pyun YongHyeon wrote: > > No, it seems there is other issue in brgphy(4). I noticed brgphy(4) > > blindly try to set jumbo frame related registers. I guess the PHY > > may not have the register. Back out previous patch and try this > > one. > > Thanks, works better (the error message is gone), but still negotiates > at 10baseT/UTP fdx... See attached dmesg.out. Hmm, try this one and let me know it make any differences. --NU0Ex4SbNnrxsi6C Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="BCM57780.diff3" Index: sys/dev/mii/miidevs =================================================================== --- sys/dev/mii/miidevs (revision 205052) +++ sys/dev/mii/miidevs (working copy) @@ -81,6 +81,7 @@ oui xxALTIMA 0x000895 Altima Communications oui xxBROADCOM 0x000818 Broadcom Corporation oui xxBROADCOM_ALT1 0x0050ef Broadcom Corporation +oui xxBROADCOM_ALT2 0x00d897 Broadcom Corporation oui xxICS 0x00057d Integrated Circuit Systems oui xxSEEQ 0x0005be Seeq oui xxSIS 0x000760 Silicon Integrated Systems @@ -150,6 +151,7 @@ model xxBROADCOM_ALT1 BCM5784 0x003a BCM5784 10/100/1000baseTX PHY model xxBROADCOM_ALT1 BCM5709C 0x003c BCM5709C 10/100/1000baseTX PHY model xxBROADCOM_ALT1 BCM5761 0x003d BCM5761 10/100/1000baseTX PHY +model xxBROADCOM_ALT2 BCM57780 0x0019 BCM57780 10/100/1000baseTX PHY model BROADCOM2 BCM5906 0x0004 BCM5906 10/100baseTX PHY /* Cicada Semiconductor PHYs (now owned by Vitesse?) */ Index: sys/dev/mii/brgphy.c =================================================================== --- sys/dev/mii/brgphy.c (revision 205052) +++ sys/dev/mii/brgphy.c (working copy) @@ -139,6 +139,7 @@ MII_PHY_DESC(xxBROADCOM_ALT1, BCM5784), MII_PHY_DESC(xxBROADCOM_ALT1, BCM5709C), MII_PHY_DESC(xxBROADCOM_ALT1, BCM5761), + MII_PHY_DESC(xxBROADCOM_ALT2, BCM57780), MII_PHY_DESC(BROADCOM2, BCM5906), MII_PHY_END }; @@ -213,6 +214,7 @@ switch (bsc->mii_oui) { case MII_OUI_BROADCOM: case MII_OUI_BROADCOM2: + case MII_OUI_xxBROADCOM_ALT2: break; case MII_OUI_xxBROADCOM: switch (bsc->mii_model) { @@ -678,16 +680,18 @@ brgphy_mii_phy_auto(struct mii_softc *sc) { struct brgphy_softc *bsc = (struct brgphy_softc *)sc; + uint16_t anar; int ktcr = 0; brgphy_reset(sc); /* Enable flow control in the advertisement register. */ if ((sc->mii_flags & MIIF_HAVEFIBER) == 0) { + anar = PHY_READ(sc, BRGPHY_MII_ANAR) & BRGPHY_ANAR_NP; /* Pause capability advertisement (pause capable & asymmetric) */ PHY_WRITE(sc, BRGPHY_MII_ANAR, BMSR_MEDIA_TO_ANAR(sc->mii_capabilities) | ANAR_CSMA | - BRGPHY_ANAR_ASP | BRGPHY_ANAR_PC); + BRGPHY_ANAR_ASP | BRGPHY_ANAR_PC | anar); } else { PHY_WRITE(sc, BRGPHY_SERDES_ANAR, BRGPHY_SERDES_ANAR_FDX | BRGPHY_SERDES_ANAR_HDX | BRGPHY_SERDES_ANAR_BOTH_PAUSE); @@ -1021,7 +1025,8 @@ if (bge_sc->bge_flags & BGE_FLAG_JITTER_BUG) brgphy_fixup_jitter_bug(sc); - brgphy_jumbo_settings(sc, ifp->if_mtu); + if (bge_sc->bge_flags & BGE_FLAG_JUMBO) + brgphy_jumbo_settings(sc, ifp->if_mtu); if (bge_sc->bge_flags & BGE_FLAG_WIRESPEED) brgphy_ethernet_wirespeed(sc); --NU0Ex4SbNnrxsi6C--