From owner-freebsd-acpi@FreeBSD.ORG Mon Apr 19 20:48:02 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8B8116A4CE for ; Mon, 19 Apr 2004 20:48:02 -0700 (PDT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 86A7043D1F for ; Mon, 19 Apr 2004 20:48:02 -0700 (PDT) (envelope-from nate@root.org) Received: (qmail 25019 invoked by uid 1000); 20 Apr 2004 03:48:04 -0000 Date: Mon, 19 Apr 2004 20:48:04 -0700 (PDT) From: Nate Lawson To: Bruno Ducrot In-Reply-To: <20040419101059.GB13861@poupinou.org> Message-ID: <20040419204522.W25001@root.org> References: <20040419101059.GB13861@poupinou.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-acpi@freebsd.org Subject: Re: [PATCH] NULL pointer checking in acpi_pcib.c X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2004 03:48:02 -0000 On Mon, 19 Apr 2004, Bruno Ducrot wrote: > I have some little problem (probably a bug in the DSDT, I'm not sure) if > there is not check for crsbuf.Pointer in acpi_pcib_route_interrupt() > after calling acpi_AppendBufferResource(). > My latop hang if AC is off-line on boot, or even at runtime. > > I'm not sure if that correct, though, but acpi_pci_link_set_irq() will > do this checking anyway, so I guess it's expected that the caller > have to check the return value for crsbuff.Pointer after the call to > acpi_AppendBufferResource(&crsbuf, ...). Can you add some printfs before the NULL check I committed so that we can figure out what resource is causing this trouble? Printing the contents of *res when crsbuf.Pointer == NULL would help. Also a copy of your ASL (from acpidump -t -d) would be good. -Nate