From owner-svn-src-all@FreeBSD.ORG Thu Jan 15 02:05:42 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 621131065670; Thu, 15 Jan 2009 02:05:42 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 081668FC0A; Thu, 15 Jan 2009 02:05:41 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n0F251aB058011; Wed, 14 Jan 2009 19:05:01 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 14 Jan 2009 19:05:27 -0700 (MST) Message-Id: <20090114.190527.1058804377.imp@bsdimp.com> To: stas@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20090115020752.52566769.stas@FreeBSD.org> References: <200901142232.n0EMWhGw055895@svn.freebsd.org> <20090115020752.52566769.stas@FreeBSD.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, gonzo@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r187251 - head/sys/mips/malta X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2009 02:05:42 -0000 In message: <20090115020752.52566769.stas@FreeBSD.org> Stanislav Sedov writes: : > + shift = 8 * (reg & 3); : > : : Would it make sense to replace this with : > + shift = (reg & 3) << 3; : : to not rely on possible compiler optimizations? I don't think that it matters all that much these days... Warner