From owner-svn-src-head@FreeBSD.ORG Fri May 22 13:21:41 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 99F931065675; Fri, 22 May 2009 13:21:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 6901E8FC0A; Fri, 22 May 2009 13:21:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id F382346B90; Fri, 22 May 2009 09:21:40 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 9327D8A025; Fri, 22 May 2009 09:21:39 -0400 (EDT) From: John Baldwin To: Attilio Rao Date: Fri, 22 May 2009 09:21:34 -0400 User-Agent: KMail/1.9.7 References: <3bbf2fe10905210629p46c7a204v6863aaba77354462@mail.gmail.com> <20090521194243.GW1927@deviant.kiev.zoral.com.ua> <3bbf2fe10905211511g53defb6cmac45fc2469cc64f@mail.gmail.com> In-Reply-To: <3bbf2fe10905211511g53defb6cmac45fc2469cc64f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905220921.34785.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 22 May 2009 09:21:39 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Scott Long , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, rwatson@freebsd.org, Kostik Belousov , "M. Warner Losh" Subject: Re: svn commit: r192535 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2009 13:21:42 -0000 On Thursday 21 May 2009 6:11:02 pm Attilio Rao wrote: > At this point I wonder what's the purpose of maintaining the sleeping > version for such functions? Actually, I still very much do not like using M_NOWAIT needlessly. I would much rather the solution for make_dev() be that the 1 or 2 places that need to do it with a mutex held instead queue a task to do the actual make_dev() in a taskqueue when no locks are held. This is basically what destroy_dev_sched() is doing. Perhaps a make_dev_sched() with a similar callback to be called on completion would be better. Having a device driver do all the work to setup the hardware only to fail to create a node in /dev so that userland can actually use it is pretty rediculous and useless. -- John Baldwin