From owner-freebsd-stable@FreeBSD.ORG  Tue Oct 25 17:12:15 2005
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
X-Original-To: freebsd-stable@FreeBSD.org
Delivered-To: freebsd-stable@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 11BE716A41F;
	Tue, 25 Oct 2005 17:12:15 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A6F9C43D76;
	Tue, 25 Oct 2005 17:12:10 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j9PHC8Ic079508
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 25 Oct 2005 21:12:09 +0400 (MSD)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.13.3/8.13.1/Submit) id j9PHC7G5079507;
	Tue, 25 Oct 2005 21:12:07 +0400 (MSD)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Tue, 25 Oct 2005 21:12:07 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Max Laier <max@love2party.net>
Message-ID: <20051025171207.GQ41520@cell.sick.ru>
References: <20051023074342.GA97095@dun.ukr.net>
	<20051025150018.GO41520@cell.sick.ru>
	<200510251804.37929.max@love2party.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200510251804.37929.max@love2party.net>
User-Agent: Mutt/1.5.6i
Cc: Pete French <petefrench@ticketswitch.com>, freebsd-stable@FreeBSD.org,
	csjp@FreeBSD.org, Vladimir Sharun <sharun@ukr.net>,
	Kris Kennaway <kris@obsecurity.org>
Subject: Re: kmem_malloc(4096): kmem_map too small: 536870912 total allocated
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Oct 2005 17:12:15 -0000

On Tue, Oct 25, 2005 at 06:04:15PM +0200, Max Laier wrote:
M> On Tuesday 25 October 2005 17:00, Gleb Smirnoff wrote:
M> >   Vladimir,
M> >
M> >   please confirm that the attached patch fix your problem. The patch is
M> > relative to src/sys tree.
M> >
M> >   Kris, Christian, please review it. Thanks.
M> 
M> Are you sure it's safe to free the nlminfo struct before calling to fdfree() 
M> in exit1()?  It sounds like it might need the structure if there are pending 
M> locks?  Just a guess, though.

The locks are actually held on the server side, so we aren't leaking
them here. Anyway, the fix is directly from BSD/OS, from where
nlminfo have came from.

M> On a side note, there are some whitespace errors in and before 
M> nlminfo_release().

Thanks. I'll take this into account.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE