From owner-svn-src-head@FreeBSD.ORG  Fri Jul  5 00:03:54 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 3DAADABC;
 Fri,  5 Jul 2013 00:03:54 +0000 (UTC)
 (envelope-from adrian@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 2FFCE162A;
 Fri,  5 Jul 2013 00:03:54 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r6503sRi000392;
 Fri, 5 Jul 2013 00:03:54 GMT (envelope-from adrian@svn.freebsd.org)
Received: (from adrian@localhost)
 by svn.freebsd.org (8.14.7/8.14.5/Submit) id r6503sD8000391;
 Fri, 5 Jul 2013 00:03:54 GMT (envelope-from adrian@svn.freebsd.org)
Message-Id: <201307050003.r6503sD8000391@svn.freebsd.org>
From: Adrian Chadd <adrian@FreeBSD.org>
Date: Fri, 5 Jul 2013 00:03:54 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r252736 - head/sys/net80211
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jul 2013 00:03:54 -0000

Author: adrian
Date: Fri Jul  5 00:03:53 2013
New Revision: 252736
URL: http://svnweb.freebsd.org/changeset/base/252736

Log:
  Document the current 11n rate selection shortcoming in the AMRR code.

Modified:
  head/sys/net80211/ieee80211_amrr.c

Modified: head/sys/net80211/ieee80211_amrr.c
==============================================================================
--- head/sys/net80211/ieee80211_amrr.c	Thu Jul  4 23:08:27 2013	(r252735)
+++ head/sys/net80211/ieee80211_amrr.c	Fri Jul  5 00:03:53 2013	(r252736)
@@ -240,6 +240,14 @@ amrr_update(struct ieee80211_amrr *amrr,
 	    amn->amn_txcnt,
 	    amn->amn_retrycnt);
 
+	/*
+	 * XXX This is totally bogus for 11n, as although high MCS
+	 * rates for each stream may be failing, the next stream
+	 * should be checked.
+	 *
+	 * Eg, if MCS5 is ok but MCS6/7 isn't, and we can go up to
+	 * MCS23, we should skip 6/7 and try 8 onwards.
+	 */
 	if (is_success(amn)) {
 		amn->amn_success++;
 		if (amn->amn_success >= amn->amn_success_threshold &&