From owner-cvs-src@FreeBSD.ORG Mon Apr 26 19:09:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15F1616A4CE; Mon, 26 Apr 2004 19:09:18 -0700 (PDT) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76ED243D31; Mon, 26 Apr 2004 19:09:17 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87])i3R29F5v011964; Tue, 27 Apr 2004 12:09:15 +1000 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i3R29DHW012639; Tue, 27 Apr 2004 12:09:14 +1000 Date: Tue, 27 Apr 2004 12:09:11 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Bosko Milekic In-Reply-To: <200404261513.i3QFDkb5026044@repoman.freebsd.org> Message-ID: <20040427115536.W7721@gamplex.bde.org> References: <200404261513.i3QFDkb5026044@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/mount Makefile mount.c src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2004 02:09:18 -0000 On Mon, 26 Apr 2004, Bosko Milekic wrote: > bmilekic 2004/04/26 08:13:46 PDT > > FreeBSD src repository > > Modified files: > sbin/mount Makefile mount.c > sys/ufs/ffs ffs_vfsops.c > Log: > The previous change to mount(8) to report ufs or ufs2 used > libufs, which only works for Charlie root. > > This change reverts the introduction of libufs and moves the > check into the kernel. Since the f_fstypename is the same > for both ufs and ufs2, we check fs_magic for presence of > ufs2 and copy "ufs2" explicitly instead. This seems to fix things like "mount -t ufs" and "find / -fstype ufs" to not work with ufs2. Many scripts may depend on this. Is it too late to fix the misspelling of "ffs" as "ufs"? The patch has some bugs (mainly clobbering of mp->mnt_stat.f_fstypename via an alias in the first part of the change to ffs_statfs(), so the larger second part of the change is a no-op). Details in private mail. Bruce