From owner-freebsd-current@FreeBSD.ORG  Mon May 30 03:11:00 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 267DE16A41C
	for <freebsd-current@freebsd.org>; Mon, 30 May 2005 03:11:00 +0000 (GMT)
	(envelope-from kiyohara@kk.iij4u.or.jp)
Received: from r-kk.iij4u.or.jp (r-kk.iij4u.or.jp [210.130.0.73])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AA7D543D1D
	for <freebsd-current@freebsd.org>; Mon, 30 May 2005 03:10:59 +0000 (GMT)
	(envelope-from kiyohara@kk.iij4u.or.jp)
Received: from localhost (h150.p084.iij4u.or.jp [210.130.84.150])
	by r-kk.iij4u.or.jp (8.11.6+IIJ/8.11.6) with ESMTP id j4U3AvV18943;
	Mon, 30 May 2005 12:10:58 +0900 (JST)
Date: Mon, 30 May 2005 12:10:56 +0900 (JST)
Message-Id: <20050530.121056.74739774.kiyohara@kk.iij4u.or.jp>
To: freebsd-current@freebsd.org
From: KIYOHARA Takashi <kiyohara@kk.iij4u.or.jp>
X-Mailer: Mew version 2.3 on Emacs 20.7 / Mule 4.1 (AOI)
Mime-Version: 1.0
Content-Type: Multipart/Mixed;
	boundary="--Next_Part(Mon_May_30_12:10:56_2005_364)--"
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Mon, 30 May 2005 11:40:35 +0000
Cc: kiyohara@kk.iij4u.or.jp
Subject: fwcontrol patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 May 2005 03:11:00 -0000

----Next_Part(Mon_May_30_12:10:56_2005_364)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi! all.


I request to change for usr.sbin/fwcontrol/fwcontrol.c.

  1. Return value of sysctl_set_int() is int. But no return.
  2. indent miss in main().


Thanks
--
kiyohara


----Next_Part(Mon_May_30_12:10:56_2005_364)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="fwcontrol.c.diff"

--- fwcontrol.c.orig	2005-05-30 11:56:26.000000000 +0900
+++ fwcontrol.c	2005-05-30 11:56:38.000000000 +0900
@@ -608,6 +608,7 @@
 {
 	if (sysctlbyname(name, NULL, NULL, &val, sizeof(int)) < 0)
 		err(1, "sysctl %s failed.", name);
+	return (0);
 }
 
 int
@@ -655,8 +656,8 @@
 			show_crom(crom_buf);
 			break;
 		case 'm':
-		       if (eui64_hostton(optarg, &target) != 0 &&
-			   eui64_aton(optarg, &target) != 0)
+			if (eui64_hostton(optarg, &target) != 0 &&
+			    eui64_aton(optarg, &target) != 0)
 				errx(1, "invalid target: %s", optarg);
 			eui.hi = ntohl(*(u_int32_t*)&(target.octet[0]));
 			eui.lo = ntohl(*(u_int32_t*)&(target.octet[4]));

----Next_Part(Mon_May_30_12:10:56_2005_364)----