Date: Wed, 14 Sep 2005 03:17:59 +0200 (CEST) From: Roman Neuhauser <neuhauser@sigpipe.cz> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/86098: [PATCH] devel/pear-PEAR/Makefile.common: allow use by foreign packages Message-ID: <20050914011759.A647A1F87BEF@isis.sigpipe.cz> Resent-Message-ID: <200509140120.j8E1K0EB032485@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 86098
>Category: ports
>Synopsis: [PATCH] devel/pear-PEAR/Makefile.common: allow use by foreign packages
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Sep 14 01:20:00 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Roman Neuhauser
>Release: FreeBSD 4.10-STABLE i386
>Organization:
>Environment:
>Description:
(maintainer cced)
The attached patch allows ports for packages from outside pear.php.net
use devel/pear-PEAR/Makefile.common by only setting MASTER_SITES et al.
when PEAR_ALIEN is not defined.
A bit of background:
I received a PR updating devel/simpletest I maintain from (a year old)
1.0RC1 to 1.0.
The author of SimpleTest released two tarballs for the 1.0 version, one
of them constitutes a pear(1) installable package (contains package.xml;
alas, misses the documentation, but that's beside the point), and the
submitter of the PR chose to base the patch on the pear compatible
tarball and .included Makefile.common (previous version of
devel/simpletest/Makefile had pieces of it copypasted).
That created a problem: Makefile.common sets MASTER_SITES etc.
unconditionally. That's easily fixed, but this patch made me think:
should pearified but non-pear.php.net packages acquire the pear-
PKGNAMEPREFIX or not? Porter's Handbook says
pear* Ports related to the Pear PHP framework.
but how much is software like SimpleTest related? I guess it should
have the prefix, it installs under /usr/local/share/pear after all..
I don't really have an opinion, but the ability to use the
Makefile.common code in ports for packages coming from outside
pear.php.net is nice with or without PKGNAMEPREFIX.
>How-To-Repeat:
>Fix:
--- devel::pear-PEAR::Makefile.common-PEAR_ALIEN,0.patch begins here ---
Index: devel/pear-PEAR/Makefile.common
===================================================================
RCS file: /home/ncvs/ports/devel/pear-PEAR/Makefile.common,v
retrieving revision 1.13
diff -u -r1.13 Makefile.common
--- devel/pear-PEAR/Makefile.common 21 Feb 2005 18:05:04 -0000 1.13
+++ devel/pear-PEAR/Makefile.common 13 Sep 2005 23:51:09 -0000
@@ -2,12 +2,14 @@
# Common code for pear- ports.
+.if !defined(PEAR_ALIEN)
MASTER_SITES= http://pear.php.net/get/
PKGNAMEPREFIX= pear-
EXTRACT_SUFX= .tgz
DIST_SUBDIR= PEAR
USE_REINPLACE= yes
+.endif
.if !defined(USE_PHPIZE)
NO_BUILD= yes
--- devel::pear-PEAR::Makefile.common-PEAR_ALIEN,0.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050914011759.A647A1F87BEF>