From owner-freebsd-bugs@FreeBSD.ORG  Thu Jul 29 16:50:02 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C352F1065675
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 29 Jul 2010 16:50:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B20BC8FC16
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 29 Jul 2010 16:50:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6TGo2Pw058131
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 29 Jul 2010 16:50:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6TGo2hm058126;
	Thu, 29 Jul 2010 16:50:02 GMT (envelope-from gnats)
Date: Thu, 29 Jul 2010 16:50:02 GMT
Message-Id: <201007291650.o6TGo2hm058126@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: bin/40282: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2010 16:50:02 -0000

The following reply was made to PR bin/40282; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/40282: commit references a PR
Date: Thu, 29 Jul 2010 16:40:55 +0000 (UTC)

 Author: jilles
 Date: Thu Jul 29 16:40:45 2010
 New Revision: 210613
 URL: http://svn.freebsd.org/changeset/base/210613
 
 Log:
   kill: Stop processing if a syntactically invalid pid is encountered.
   
   So a command like
     kill _HUP 1
   now fails without sending SIGTERM to init.
   
   The behaviour when kill(2) fails remains unchanged: processing continues.
   This matches other implementations and POSIX and is useful for killing
   multiple processes at once when some of them may already be gone.
   
   PR:		bin/40282
 
 Modified:
   head/bin/kill/kill.c
 
 Modified: head/bin/kill/kill.c
 ==============================================================================
 --- head/bin/kill/kill.c	Thu Jul 29 16:30:27 2010	(r210612)
 +++ head/bin/kill/kill.c	Thu Jul 29 16:40:45 2010	(r210613)
 @@ -123,10 +123,9 @@ main(int argc, char *argv[])
  
  	for (errors = 0; argc; argc--, argv++) {
  		pid = strtol(*argv, &ep, 10);
 -		if (!**argv || *ep) {
 -			warnx("illegal process id: %s", *argv);
 -			errors = 1;
 -		} else if (kill(pid, numsig) == -1) {
 +		if (!**argv || *ep)
 +			errx(1, "illegal process id: %s", *argv);
 +		else if (kill(pid, numsig) == -1) {
  			warn("%s", *argv);
  			errors = 1;
  		}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"