Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Dec 2019 23:30:29 +0000
From:      Dima Pasechnik <dimpase+freebsd@gmail.com>
To:        Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc:        Adam Weinberger <adamw@adamw.org>, FreeBSD Ports <freebsd-ports@freebsd.org>
Subject:   Re: python36 is still broken.
Message-ID:  <CAAWYfq16ik9ZnRWFZjZPQEHsi9q=n==OWie5=rPN3z1LNFsm6w@mail.gmail.com>
In-Reply-To: <20191206230329.GC949@troutmask.apl.washington.edu>
References:  <20191206184050.GA44417@troutmask.apl.washington.edu> <CAP7rwcj00Z81VBJ47dFfn1RUJFCb1rBAW77pP7Wj=BxRdZFp6g@mail.gmail.com> <20191206230329.GC949@troutmask.apl.washington.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
The patch in question is in Python 3.7, cf.
https://github.com/python/cpython/pull/12046
how about switching to this version?

On Fri, Dec 6, 2019 at 11:03 PM Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
>
> On Fri, Dec 06, 2019 at 03:49:46PM -0700, Adam Weinberger wrote:
> > On Fri, Dec 6, 2019 at 11:41 AM Steve Kargl
> > <sgk@troutmask.apl.washington.edu> wrote:
> > >
> > > This has been reported for many years and there are open bug reports.
> > > Any chance that the this will be fixed.
> > >
> > >
> > > --- work/Python-3.6.9/Modules/mathmodule.c.orig 2019-12-06 10:33:39.232673000 -0800
> > > +++ work/Python-3.6.9/Modules/mathmodule.c      2019-12-06 10:34:53.288616000 -0800
> > > @@ -67,7 +67,7 @@
> > >  static const double logpi = 1.144729885849400174143427351353058711647;
> > >
> > >  static double
> > > -sinpi(double x)
> > > +a_really_bad_idea_sinpi(double x)
> > >  {
> > >      double y, r;
> > >      int n;
> > > @@ -296,7 +296,7 @@
> > >         integer. */
> > >      if (absx > 200.0) {
> > >          if (x < 0.0) {
> > > -            return 0.0/sinpi(x);
> > > +            return 0.0/a_really_bad_idea_sinpi(x);
> > >          }
> > >          else {
> > >              errno = ERANGE;
> >
> > Hi Steve,
> >
> > WIthout context it's hard to advise. What PRs with that patch exist?
> > Have they been responded to or have they been ignored? Team immunity
> > from PR timeouts no longer exists, so if the problem needs a fix let's
> > fix it.
> >
>
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232792
>
> As noted in the PR, it has been reported to the lists
>
> https://lists.freebsd.org/pipermail/freebsd-ports/2017-June/109093.html
> https://lists.freebsd.org/pipermail/freebsd-ports/2017-September/110229.html
>
> I'll refrain from commenting further.
>
> --
> Steve
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAWYfq16ik9ZnRWFZjZPQEHsi9q=n==OWie5=rPN3z1LNFsm6w>