From owner-freebsd-emulation@FreeBSD.ORG Wed Jan 26 23:33:24 2011 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D1D3D106566C for ; Wed, 26 Jan 2011 23:33:24 +0000 (UTC) (envelope-from decke@FreeBSD.org) Received: from groupware.itac.at (groupware.itac.at [91.205.172.99]) by mx1.freebsd.org (Postfix) with ESMTP id 67ED88FC08 for ; Wed, 26 Jan 2011 23:33:24 +0000 (UTC) Received: from home.bluelife.at (93.104.210.95) by groupware.itac.at (Axigen) with (AES256-SHA encrypted) ESMTPSA id 0B5E1C; Thu, 27 Jan 2011 00:35:28 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Date: Thu, 27 Jan 2011 00:33:24 +0100 From: Bernhard Froehlich To: Mikolaj Golub In-Reply-To: <86ei7z4aps.fsf@kopusha.home.net> References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org> <86tygwy9p0.fsf@kopusha.home.net> "<20110126091038.C3489@maildrop.int.zabbadoz.net>" <86aainkbhb.fsf@zhuzha.ua1> <20110126141636.D3489@maildrop.int.zabbadoz.net> <86ei7z4aps.fsf@kopusha.home.net> Message-ID: <44307214e4381602f6381d6a78ded1e2@bluelife.at> X-Sender: decke@FreeBSD.org User-Agent: Roundcube Webmail/0.5-rc X-AxigenSpam-Level: 1 X-CTCH-RefID: str=0001.0A0B0208.4D40AF43.0033,ss=1,fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Cc: "Bjoern A. Zeeb" , freebsd-emulation@freebsd.org Subject: Re: VirtualBox + VIMAGE X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2011 23:33:24 -0000 On Wed, 26 Jan 2011 23:27:27 +0200, Mikolaj Golub wrote: > On Wed, 26 Jan 2011 14:18:03 +0000 (UTC) Bjoern A. Zeeb wrote: > > BAZ> On Wed, 26 Jan 2011, Mikolaj Golub wrote: > > >> > >> On Wed, 26 Jan 2011 09:15:46 +0000 (UTC) Bjoern A. Zeeb wrote: > >> > >> BAZ> I think you should wrap the CURVNET changes in __FreeBSD_version > >> BAZ> checks so that the port, should it run elsewhere or on older > FreeBSDs > >> BAZ> (if it runs there) not trouble people having to patch it away. > >> > >> BAZ> #if defined(__FreeBSD_version) && __FreeBSD_version >= 800500 > >> BAZ> #endif > >> > >> BAZ> might be a save bet. > >> > >> Thanks. Something like in the patch below? > >> > >> Note, I have not run this version yet. Will test it tonight or tomorrow. > > BAZ> Well, you will need to include as well, and that only if > BAZ> you are on FreeBSD so you'll need an extra check for just that I > BAZ> guess. Not sure how vbox handles the all this in their guts. > > The file has already had '#include ' among other includes. It > just is not seen in the patch. The file is used only for FreeBSD driver so > there is no need in extra check I think. > > I have tested this latest version of the patch. It works for me. Could someone with a vimage enabled kernel please test bridging with a stock emulators/virtualbox-ose-kmod port? There was a report that this causes a crash and it would be good to verify if that is still valid: http://lists.freebsd.org/pipermail/freebsd-emulation/2009-November/007055.html -- Bernhard Froehlich http://www.bluelife.at/