From owner-freebsd-ruby@freebsd.org Fri Jun 30 10:05:04 2017 Return-Path: Delivered-To: freebsd-ruby@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86B52D8D7F6 for ; Fri, 30 Jun 2017 10:05:04 +0000 (UTC) (envelope-from vanilla@fatpipi.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 5F5AA323E for ; Fri, 30 Jun 2017 10:05:04 +0000 (UTC) (envelope-from vanilla@fatpipi.com) Received: by mailman.ysv.freebsd.org (Postfix) id 5B5A5D8D7F5; Fri, 30 Jun 2017 10:05:04 +0000 (UTC) Delivered-To: ruby@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58F27D8D7F3 for ; Fri, 30 Jun 2017 10:05:04 +0000 (UTC) (envelope-from vanilla@fatpipi.com) Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F0B7A323C for ; Fri, 30 Jun 2017 10:05:03 +0000 (UTC) (envelope-from vanilla@fatpipi.com) Received: by mail-wm0-x22b.google.com with SMTP id w126so105270130wme.0 for ; Fri, 30 Jun 2017 03:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fatpipi-com.20150623.gappssmtp.com; s=20150623; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc; bh=A7rfiG5VmSJBLPWi2pXQRqgS0cT0jtGxp2qvMEoHEhk=; b=QNPk3P/6qf8cHiopod7eb5tBKsQjp5AejMJIVCIdXtEzwT78Nz/DA3qDbkvyTlfbLa 1ip68AFyNYI/ToPA2ayeRIXW+vv5mq3wodKPYEy6w5N+rJz2VxjEZaBeqkwNmlQt7aox cGhR6Eo0tEaT/2kFK0hYSokjp8qkD2iYHPH8YXLcoO4YyDgudM10dWQUUQ4DaokpGLBZ lJoCA5dt6W67oGAnMFnFTqxAwBfSxzgtTmMNPz/auaNDZAiJ2WH5uRq4sz38uwW3KOkK tx1pPYSP8Kup9G0kB8HlOhkER8AdBJDomwY6n8fmgK5LaJ7pGsvLP2HJKRc0hWjOzNGf 8FQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=A7rfiG5VmSJBLPWi2pXQRqgS0cT0jtGxp2qvMEoHEhk=; b=Bu+EgKBrmrz6uyEYNyOFXaF9nq8Bvrv+uyArV7HNqFdmEx9QXlbqeMbXplM8kYj760 g7n3yU4nvuERt4La/GQQxkDnBqqXhb3jPES1NGkDeHmVNv/P+PWujF67Vp31pcsZxIr5 AV3bDEXTa6OD7Kq5cNr5gBcP0mxqT1wJqFu3Annman3pF5ecwLGSCFzFg0n2W15cwwgi y53gl1GEkRgx1r+mqAA2vVb/TmEfm8nAkQDyTCFEZsKTUn2XW0Hh+5SfM5tqir3GabAf laMdGEKm6WhM1jfHGW3wsEd42JK5sXREhgIdGV/AcsVMHJCvS321r85+ldnm86G0VW8O DtHw== X-Gm-Message-State: AKS2vOzmOsENMLfK3MEYupoLExMUy5THfhq/ymz8cCElMFpWe5imbnP6 pEEWuPX1QcmLOfGFKGmk9nRE7jDREF9p X-Received: by 10.28.5.19 with SMTP id 19mr14294713wmf.120.1498817101612; Fri, 30 Jun 2017 03:05:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.171.71 with HTTP; Fri, 30 Jun 2017 03:05:01 -0700 (PDT) Reply-To: v@fatpipi.com In-Reply-To: <412f42ff-e5e7-03e8-fcbd-10d86d0c072c@mouf.net> References: <4474b97e-88ec-ead8-bb13-79e5889bf237@FreeBSD.org> <2369ae1e-30cb-52d7-6697-a99139d74479@mouf.net> <029a9c1f-de69-3bfd-ff89-1a02feb767a0@fechner.net> <412f42ff-e5e7-03e8-fcbd-10d86d0c072c@mouf.net> From: Vanilla Hsu Date: Fri, 30 Jun 2017 18:05:01 +0800 Message-ID: Subject: Re: Help needed: net/rubygem-grpc To: Steve Wills Cc: Matthias Fechner , Torsten Zuehlsdorff , ruby@freebsd.org, "Vanilla I. Shu" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-ruby@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: FreeBSD-specific Ruby discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 10:05:04 -0000 Hi: I update devel/grpc to 1.4.1, and change boringssl's url to official one. please try it again, thanks. 2017-06-30 0:11 GMT+08:00 Steve Wills : > Hi, > > On 06/28/2017 14:08, Matthias Fechner wrote: > > Thanks Steve, > > > > I already added it into our repository we work with: > > http://gitlab.toco-domains.de/FreeBSD/GitLab/commits/9.1 > > > > I hope that is ok for you? > > My poudiere is just building and I think it will take the full night: > > https://pkg.fechner.net/index.html > > > > I will try to do some tests (at least give the build a try). As I do not > have any experience with ruby, I do not really have an idea how to test it. > > > > That's not going to work as is, see my previous message. > > I have committed a port for boringssl and patched devel/grpc to use it > and updated the rubygem-grpc patch. See attached (as always, let me know > if it doesn't come through). > > Note this will make boringssl a runtime dep of GitLab (via rubygem-grpc > via grpc). This lets rubygem-grpc pass it's tests, except for 1, which > seems like just a test which needs updating. > > If you want to run the tests, copy these files/directories: > > Gemfile > Rakefile > src/proto > src/ruby/.rubocop.yml > src/ruby/.rubocop_todo.yml > > from the devel/grpc WRKSRC to the corresponding location in the > rubygem-grpc WRKSRC. Then install rubygem-bundler, run "bundle install" > and finally run "rake" to actually execute the tests and see results. > (Bundler will install a bunch of gems outside pkg, so you may want to do > this in a throwaway jail, such as in poudriere testport -i). > > Vanilla, could you commit the devel/grpc parts of the attached patch, or > approve me committing it? > > I think it's better to create a separate port for boringssl and use it > than to have both devel/grpc and net/rubygem-grpc bundle it. I know > boringssl isn't meant to be used this way, based on the docs. But I > think it's better to avoid bundling it, because bundling allows to > possibly use different versions in different ports and also means more > work to update it. > > Also, the github mirror used for the currently bundling of boringssl in > devel/grpc (github.com/boringssl/boringssl) is an unofficial mirror that > seems to have died a while ago. This uses the > github.com/google/boringssl mirror which seems current and updating. So > if we are against this change to devel/grpc we should at least update > the bundled version of boringssl there to the newer repo and version. > > Thanks, > Steve >