From owner-freebsd-hackers@FreeBSD.ORG  Wed Oct 21 09:03:43 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6F00B1065698;
	Wed, 21 Oct 2009 09:03:43 +0000 (UTC) (envelope-from ady@ady.ro)
Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27])
	by mx1.freebsd.org (Postfix) with ESMTP id DBC3F8FC2F;
	Wed, 21 Oct 2009 09:03:42 +0000 (UTC)
Received: by ey-out-2122.google.com with SMTP id 9so1433692eyd.9
	for <multiple recipients>; Wed, 21 Oct 2009 02:03:41 -0700 (PDT)
MIME-Version: 1.0
Sender: ady@ady.ro
Received: by 10.210.7.24 with SMTP id 24mr2457930ebg.53.1256115821251; Wed, 21 
	Oct 2009 02:03:41 -0700 (PDT)
In-Reply-To: <200910210311.54871.max@love2party.net>
References: <hbhquj$mkj$1@ger.gmane.org> <20091019140806.GB95902@rink.nu> 
	<200910210311.54871.max@love2party.net>
From: Adrian Penisoara <ady@freebsd.ady.ro>
Date: Wed, 21 Oct 2009 11:03:21 +0200
X-Google-Sender-Auth: f153f60b47a3b80a
Message-ID: <78cb3d3f0910210203n66b0b08bl1bbfb3db7ec7e024@mail.gmail.com>
To: Max Laier <max@love2party.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-hackers@freebsd.org, Rink Springer <rink@freebsd.org>,
	Ivan Voras <ivoras@freebsd.org>
Subject: Re: Make process title - % complete
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Oct 2009 09:03:43 -0000

Hi,

On Wed, Oct 21, 2009 at 3:11 AM, Max Laier <max@love2party.net> wrote:
> On Monday 19 October 2009 16:08:06 Rink Springer wrote:
>> Hi Ivan,
>>
>> On Mon, Oct 19, 2009 at 03:52:30PM +0200, Ivan Voras wrote:
>> > if nobody objects, I'll commit it :)
>>
>> I seem to recall that setproctitle() is quite expensive to call; perhaps
>> it would make sense offer a flag to prevent make(1) from calling it? [1]
>
> Just rate-limit the setproctitle() call to once/sec or once/percentage-st=
ep
> and be done with it.

Rather try to setproctitle() in the same make process every second
with a one second initial delay (so that short lived make processes
won't be bogged down by this expensive call). And preferentially do
the timing check after returning from exec() of a child make.

 This way the stats won't be "perturbed" by the short lived make's and
only one make process will call setproctitle() at any time (except
when running "make -j" ?).

>
> I must say that trying it out on a kernel build didn't proof too useful a=
s the
> targets have vastly different runtimes, but I think it's a good addition
> nonetheless. =A0So please, go for it Ivan.
>

If you implement it, please use a control mechanism like, say, an
environment variable MAKE_TRACK_PROGRESS, which, for performance and
POLA sake, might default to disabled (including when environment is
not defined).

My 5cents,
Adrian Penisoara
EnterpriseBSD.com