From owner-svn-src-all@freebsd.org Sun Sep 1 21:21:11 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D744AE6B97; Sun, 1 Sep 2019 21:21:11 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M5jz0jgYz3NSD; Sun, 1 Sep 2019 21:21:11 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f50.google.com with SMTP id f12so7890781iog.12; Sun, 01 Sep 2019 14:21:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=5geMK8kQB+Dao9cLdhgzYCsC+V39SzGs0BXFUvNNNWg=; b=hE0ikXdHAooBXR0/MEKzLti5lFDAKPDBCEgkB3weFdlN90+UB6hn3E3qMQVbO1i1Op mS7+CmKOp3XuLXmBBx8/xf9O/Nddr5Kfl5IG3Ov2yNiZgvvMLu9NREk8XhKFgibrRrXU E/BNWqKX8a0u0DveEk+6G8LNP9LVs0j01/vW27iPiM6+glRSYq0p+/DB7SPD0Z7jW6Rl tDvaQdodSA0trKAIJwPjmqgNpjxRQDoP1gRXdc9pl46t5JwTErMOgs3cuaMd3mFRZbmO A3Fe3nfeyEWt32z3eib3A1BlStRfPRdpj68c1codxTAdkSNYbFBqDnBR8SdXgAsNbfZL Cb1g== X-Gm-Message-State: APjAAAVn1SePwej/3S8mXSiyDl2fmGcyOBMJda4acbCsJP8BBTX66ccr Ely4FJX+xsFhW4aJA7uGd2p3Brb8 X-Google-Smtp-Source: APXvYqxyQ3E6j/ZactvTC9Pp9boCxcYhIWEGCHDmrXvdvxeqw4fIfct6q+82Zsp0nWqx1IYRS45WDA== X-Received: by 2002:a05:6602:25d5:: with SMTP id d21mr29419314iop.177.1567372869827; Sun, 01 Sep 2019 14:21:09 -0700 (PDT) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com. [209.85.166.46]) by smtp.gmail.com with ESMTPSA id t3sm8018175iom.54.2019.09.01.14.21.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Sep 2019 14:21:09 -0700 (PDT) Received: by mail-io1-f46.google.com with SMTP id j4so25338439iog.11; Sun, 01 Sep 2019 14:21:09 -0700 (PDT) X-Received: by 2002:a5e:dc0b:: with SMTP id b11mr5112270iok.231.1567372869275; Sun, 01 Sep 2019 14:21:09 -0700 (PDT) MIME-Version: 1.0 References: <201909011612.x81GC5DW097846@repo.freebsd.org> <201909011932.x81JWYts004074@slippy.cwsent.com> In-Reply-To: <201909011932.x81JWYts004074@slippy.cwsent.com> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sun, 1 Sep 2019 14:20:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio To: Cy Schubert Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46M5jz0jgYz3NSD X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-5.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; HAS_REPLYTO(0.00)[cem@freebsd.org]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; RCVD_IN_DNSWL_NONE(0.00)[50.166.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-2.52)[ip: (-6.89), ipnet: 209.85.128.0/17(-3.34), asn: 15169(-2.31), country: US(-0.05)]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 21:21:11 -0000 On Sun, Sep 1, 2019 at 12:32 PM Cy Schubert wrote: > In message <201909011612.x81GC5DW097846@repo.freebsd.org>, Ed Maste writes: > > Author: emaste > > Date: Sun Sep 1 16:12:05 2019 > > New Revision: 351659 > > URL: https://svnweb.freebsd.org/changeset/base/351659 > > > > Log: > > libc: remove gets > > ... > > Should we encourage the use of gets_s() in the man page or in other doc? Hi Cy, Short version: no, we shouldn't. :-) Longer version: Annex K functions like gets_s have zero real adoption (Microsoft's APIs that inspired Annex K are not actually compatible with the version in the standards); broadly terrible APIs; and in this particular case and others, unnecessarily duplicate the functionality of existing long-standing standard C functions (e.g., fgets(3)). Also, it's been a *long* time since gets(3) was known to be extremely broken and rejected by -D_FORTIFY_SOURCE and friends; at least twenty years just going by the C99 standard. I don't think developers need an advisory about using alternatives to gets(3) at this point in time. Best, Conrad