From owner-freebsd-net@FreeBSD.ORG  Mon Aug 31 17:20:08 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9425F106568F
	for <freebsd-net@hub.freebsd.org>; Mon, 31 Aug 2009 17:20:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 820DE8FC08
	for <freebsd-net@hub.freebsd.org>; Mon, 31 Aug 2009 17:20:08 +0000 (UTC)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7VHK8no047214
	for <freebsd-net@freefall.freebsd.org>; Mon, 31 Aug 2009 17:20:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7VHK8El047213;
	Mon, 31 Aug 2009 17:20:08 GMT (envelope-from gnats)
Date: Mon, 31 Aug 2009 17:20:08 GMT
Message-Id: <200908311720.n7VHK8El047213@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Stef Walter <stef-list@memberwebs.com>
Cc: 
Subject: Re: kern/134931:[route] [fib] Route messages sent to all socket
 listeners regardless of setfib
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Stef Walter <stef-list@memberwebs.com>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Aug 2009 17:20:08 -0000

The following reply was made to PR kern/134931; it has been noted by GNATS.

From: Stef Walter <stef-list@memberwebs.com>
To: bug-followup@FreeBSD.org, count@211.ru
Cc:  
Subject: Re: kern/134931:[route] [fib] Route messages sent to all socket listeners
 regardless of setfib
Date: Mon, 31 Aug 09 17:20:06 UTC

 This is a multi-part message in MIME format.
 --------------030509050508050401080102
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 As it currently stands, using routing daemons + multiple fibs in FreeBSD
 7.x and 8.x is pretty much broken. Here's a patch which fixes the problem.
 
 I agree in principle with Mark that having future route messages might
 be able to let routing daemons differentiate between various fibs and
 manage them, and that this might be a feature.... However any
 implementation of that would likely break API and ABI, and very probably
 exist purely in FreeBSD 9.x.
 
 All the best,
 
 Stef
 
 --------------030509050508050401080102
 Content-Type: text/x-diff;
  name="freebsd-route-messages-respect-fib.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="freebsd-route-messages-respect-fib.patch"
 
 --- sys/net/rtsock.c.orig	2009-08-31 15:26:03.000000000 +0000
 +++ sys/net/rtsock.c	2009-08-31 16:07:06.000000000 +0000
 @@ -777,4 +777,5 @@
  	}
  	if (m) {
 +		M_SETFIB(m, so->so_fibnum);
  		if (rp) {
  			/*
 --- sys/net/raw_usrreq.c.orig	2009-08-31 16:04:58.000000000 +0000
 +++ sys/net/raw_usrreq.c	2009-08-31 16:05:11.000000000 +0000
 @@ -84,4 +84,7 @@
  		    rp->rcb_proto.sp_protocol != proto->sp_protocol)
  			continue;
 +		if (proto->sp_family == PF_ROUTE && rp->rcb_socket &&
 +		    M_GETFIB (m) != rp->rcb_socket->so_fibnum) 
 +			continue; 
  		if (last) {
  			struct mbuf *n;
 
 --------------030509050508050401080102--