Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Dec 2020 18:29:30 +0000 (UTC)
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r368729 - in head: stand/lua tools/boot
Message-ID:  <202012171829.0BHITU4f023765@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevans
Date: Thu Dec 17 18:29:30 2020
New Revision: 368729
URL: https://svnweb.freebsd.org/changeset/base/368729

Log:
  lualoader: fix lua-lint run
  
  luacheck rightfully complains that i is unused in the show-module-options
  loop at the end (it was used for some debugging in the process).
  
  We've added a new pager module that's compiled in, so declare that as an
  acceptable global.

Modified:
  head/stand/lua/cli.lua
  head/tools/boot/lua-lint.sh

Modified: head/stand/lua/cli.lua
==============================================================================
--- head/stand/lua/cli.lua	Thu Dec 17 18:24:36 2020	(r368728)
+++ head/stand/lua/cli.lua	Thu Dec 17 18:29:30 2020	(r368729)
@@ -234,7 +234,7 @@ cli["show-module-options"] = function()
 	end
 
 	pager.open()
-	for i, v in ipairs(lines) do
+	for _, v in ipairs(lines) do
 		pager.output(v .. "\n")
 	end
 	pager.close()

Modified: head/tools/boot/lua-lint.sh
==============================================================================
--- head/tools/boot/lua-lint.sh	Thu Dec 17 18:24:36 2020	(r368728)
+++ head/tools/boot/lua-lint.sh	Thu Dec 17 18:29:30 2020	(r368729)
@@ -17,4 +17,5 @@ LUACHECK=$(which luacheck)
 cd $(make -V SRCTOP)/stand
 ${LUACHECK} . --globals loader --globals lfs --globals io.getchar \
 	--globals io.ischar --globals printc --globals cli_execute \
-	--globals cli_execute_unparsed --globals try_include --std lua53
+	--globals cli_execute_unparsed --globals try_include \
+	--globals pager --std lua53



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202012171829.0BHITU4f023765>