From owner-freebsd-usb@FreeBSD.ORG  Tue Nov  3 10:09:29 2009
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4AEC9106566B;
	Tue,  3 Nov 2009 10:09:29 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe03.swip.net [212.247.154.65])
	by mx1.freebsd.org (Postfix) with ESMTP id 785EC8FC15;
	Tue,  3 Nov 2009 10:09:28 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=CGJ8n4-NgEEA:10
	a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=uWpPHBPPO1n2KsHQQYoA:9
	a=5iJVv3YZ6Pq0fU633AEA:7 a=PflxJVr-h9pNVsi5yF4bHrAoEdcA:4
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop.adsl.tele2.no)
	by mailfe03.swip.net (CommuniGate Pro SMTP 5.2.16)
	with ESMTPA id 1339315974; Tue, 03 Nov 2009 11:09:26 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-usb@freebsd.org
Date: Tue, 3 Nov 2009 11:08:32 +0100
User-Agent: KMail/1.11.4 (FreeBSD/9.0-CURRENT; KDE/4.2.4; i386; ; )
References: <200911030952.nA39qqlq082386@www.freebsd.org>
In-Reply-To: <200911030952.nA39qqlq082386@www.freebsd.org>
X-Face: (%<A9p'; 5>:6u[ldzJ`0qjD7sCkfdMmD*RxpO<Q0yAl~?`'F?jDVb]E6TQ7'#h-VlLs}k/
	(yxg(p!IL.`#ng"%`BMrham7%UK,}VH\wUOm=^>wEEQ+KWt[{J#x6ow~JO:,zwp.(t; @Aq
	:4:&nFCgDb8[3oIeTb^'",;u{5{}C9>"PuY\)!=#\u9SSM-nz8+SR~B\!qBv
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200911031108.33332.hselasky@c2i.net>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: usb/140242: dev/usb/controller/ehci_ix4xx.c shortcomings
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2009 10:09:29 -0000

On Tuesday 03 November 2009 10:52:52 Sebastian Huber wrote:
> >Number:         140242
> >Category:       usb
> >Synopsis:       dev/usb/controller/ehci_ix4xx.c shortcomings
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       low
> >Responsible:    freebsd-usb
> >State:          open
> >Quarter:
> >Keywords:
> >Date-Required:
> >Class:          sw-bug
> >Submitter-Id:   current-users
> >Arrival-Date:   Tue Nov 03 10:00:12 UTC 2009
> >Closed-Date:
> >Last-Modified:
> >Originator:     Sebastian Huber
> >Release:        9-current
> >Organization:
>
> embedded brains GmbH
>
> >Environment:
> >Description:
>
> In ehci_ixp_attach() setting of sc->sc_bus.usbrev is superfluous since this
> is also set in ehci_init().
>
> Calling ehci_reset() without a valid sc->sc_offs value makes no sense.
>
> >How-To-Repeat:
> >
> >Fix:
>
> Index: ehci_ixp4xx.c
> ===================================================================
> --- ehci_ixp4xx.c       (revision 198848)
> +++ ehci_ixp4xx.c       (working copy)
> @@ -157,8 +157,6 @@
>                 return (ENOMEM);
>         }
>
> -       sc->sc_bus.usbrev = USB_REV_2_0;
> -
>         /* NB: hints fix the memory location and irq */
>
>         rid = 0;
> @@ -230,7 +228,6 @@
>
>                      | EHCI_SCFLG_BIGEMMIO
>                      | EHCI_SCFLG_NORESTERM
>
>                      ;
> -       (void) ehci_reset(sc);
>
>         err = ehci_init(sc);
>         if (!err) {
>
> >Release-Note:
> >Audit-Trail:
> >Unformatted:

Hi,

Thanks for your patch.

What is the correct "sc->sc_offs" value? The sc_offs field is used by more 
than reset, and should be set correctly. I.E. The right solution is not to 
remove the ehci_reset() call.

--HPS