From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Apr 30 12:40:01 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ADDA4106567A for ; Wed, 30 Apr 2008 12:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8D5318FC1D for ; Wed, 30 Apr 2008 12:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m3UCe1HV032510 for ; Wed, 30 Apr 2008 12:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m3UCe1ee032509; Wed, 30 Apr 2008 12:40:01 GMT (envelope-from gnats) Resent-Date: Wed, 30 Apr 2008 12:40:01 GMT Resent-Message-Id: <200804301240.m3UCe1ee032509@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mel Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D86AA1065676; Wed, 30 Apr 2008 12:36:45 +0000 (UTC) (envelope-from root@smoochies.rachie.is-a-geek.net) Received: from snoogles.rachie.is-a-geek.net (rachie.is-a-geek.net [66.230.99.27]) by mx1.freebsd.org (Postfix) with ESMTP id A9FFC8FC2B; Wed, 30 Apr 2008 12:36:45 +0000 (UTC) (envelope-from root@smoochies.rachie.is-a-geek.net) Received: from smoochies.rachie.is-a-geek.net (smoochies.rachie.is-a-geek.net [192.168.1.50]) by snoogles.rachie.is-a-geek.net (Postfix) with ESMTP id 6F7881CC91; Wed, 30 Apr 2008 04:17:14 -0800 (AKDT) Received: by smoochies.rachie.is-a-geek.net (Postfix, from userid 0) id 167FF28426; Wed, 30 Apr 2008 04:17:13 -0800 (AKDT) Message-Id: <20080430121714.167FF28426@smoochies.rachie.is-a-geek.net> Date: Wed, 30 Apr 2008 04:17:13 -0800 (AKDT) From: Mel To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: MAINTAINER Subject: ports/123257: [PATCH] vim options does not work as expected X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2008 12:40:01 -0000 >Number: 123257 >Category: ports >Synopsis: [PATCH] vim options does not work as expected >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Apr 30 12:40:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Mel >Release: FreeBSD 7.0-STABLE i386 >Organization: >Environment: System: FreeBSD smoochies.rachie.is-a-geek.net 7.0-STABLE FreeBSD 7.0-STABLE #5: Thu Apr 3 06:42:37 AKDT 2008 root@smoochies.rachie.is-a-geek.net:/usr/obj/usr/src/sys/GENERIC-ULE i386 >Description: When building vim with WITH_VIM_OPTIONS and not adding *any* gui, the GNOME1 gui is added regardless. There is also no option in the vim options to set the equivalent of WITHOUT_X11. >How-To-Repeat: Set WITH_VIM_OPTIONS in /etc/make.conf, type make config in /usr/ports/editors/vim, do not check any GUI, including the one advertized as GNOME1, then type make -V LIB_DEPENDS to see that gtk-1 dep has been added. Here's the current /var/db/ports/vim/options that demonstrates the case: # This file is auto-generated by 'make config'. # No user-servicable parts inside! # Options for vim-7.1.242 _OPTIONS_READ=vim-7.1.242 WITH_PERL=true WITHOUT_PYTHON=true WITHOUT_RUBY=true WITH_CSCOPE=true WITHOUT_EXUBERANT_CTAGS=true WITHOUT_ATHENA=true WITHOUT_GTK2=true WITHOUT_GNOME=true WITHOUT_MOTIF=true WITHOUT_XTERM_SAVE=true >Fix: The hack below implements the correct logic. Really what's needed is 'NO_GUI' or 'WITHOUT_X11' option in the vim options. --- editors/vim/Makefile.orig 2008-04-28 15:29:29.000000000 -0800 +++ editors/vim/Makefile 2008-04-30 03:57:52.000000000 -0800 @@ -119,7 +119,7 @@ .if !defined(WITHOUT_X11) # for now default the GUI to the GTK+ one # will be reviewed when the GTK+ 1.{3,4} behemoth is released -.if !defined(WITH_ATHENA) && !defined(WITH_MOTIF) && !defined(WITH_GNOME) && !defined(WITH_GTK2) +.if !defined(WITH_ATHENA) && !defined(WITH_MOTIF) && !defined(WITH_GNOME) && !defined(WITH_GTK2) && !defined(WITHOUT_GNOME) WITH_GNOME= gtk12 .endif >Release-Note: >Audit-Trail: >Unformatted: