From owner-freebsd-current@FreeBSD.ORG  Sat Jun 21 06:33:42 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 52EF137B401
	for <freebsd-current@Freebsd.org>;
	Sat, 21 Jun 2003 06:33:42 -0700 (PDT)
Received: from perrin.int.nxad.com (internal.ext.nxad.com [69.1.70.251])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E9F6943F85
	for <freebsd-current@Freebsd.org>;
	Sat, 21 Jun 2003 06:33:41 -0700 (PDT)	(envelope-from hmp@nxad.com)
Received: by perrin.int.nxad.com (Postfix, from userid 1072)
	id 86D122105E; Sat, 21 Jun 2003 06:33:41 -0700 (PDT)
Date: Sat, 21 Jun 2003 06:33:41 -0700
From: Hiten Pandya <hmp@FreeBSD.ORG>
To: Sean Kelly <smkelly@zombie.org>
Message-ID: <20030621133341.GC6558@perrin.int.nxad.com>
References: <20030621024707.GA73447@edgemaster.zombie.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20030621024707.GA73447@edgemaster.zombie.org>
X-Operating-System: FreeBSD FreeBSD 4.7-STABLE
User-Agent: Mutt/1.5.4i
cc: freebsd-current@Freebsd.org
Subject: Re: Software watchdog patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jun 2003 13:33:42 -0000

On Fri, Jun 20, 2003 at 09:47:07PM -0500, Sean Kelly wrote:
> Greetings.
> I look forward to any feedback, whether positive or negative.

	Hello Sean, this stuff looks really promising.  Anyways, I
	can't comment about the code as I have had no time to read it,
	but here are a few mdoc nitpicks I did:
=09
Index: share/man/man4/watchdog.4
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
+is implemented via a trio of sysctl OIDs. When
+.Va debug.watchdog.enabled

	Hmm, the .Va should be replaced with .Li.  Also, it is necessary
	to remove all hard sentence breaks, ie. instead of:

		"via a trio of sysctl OIDs.  When..."
=09
	It should be:

		"via a trio of sysctl OIDs.
		When..."
=09
	Sysctls should be documented using .Li.

+.Sh SEE ALSO
+.Xr watchdogd 8 ,
+.Xr sysctl 8
+.Sh HISTORY

	Manual pages are first ordered by their section numbers, and
	then alphabetically, thus watchdogd(8)'s .Xr should be after
	sysctl(8).
=09
+.Sh AUTHORS
+.An -nosplit
+The
+.Nm
+code and man page were written by
+.An Sean Kelly Aq smkelly@zombie.org .

	Use `manual page' instead of `man page'.
=09
	Same sort of comments apply to the watchdogd(8) manual page.

	Hope that helps.
	Cheers.

	-- Hiten (hmp@FreeBSD.ORG)